After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400970 - Don't use custom marshallers when glib provides them
Don't use custom marshallers when glib provides them
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
1.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-01-26 11:42 UTC by Ross Burton
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (31.97 KB, patch)
2007-01-26 11:48 UTC, Ross Burton 		committed Details | Review
Part 2 (412 bytes, patch)
2007-03-07 17:19 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2007-01-26 11:42:29 UTC 
e-d-s often creates its own marshallers when glib provides them already.  Attaching a patch to remove these duplicated marhallers, which often removes the build infrastructure too.
Comment 1 Ross Burton 2007-01-26 11:48:00 UTC 
Created attachment 81264 [details] [review]
Patch
Comment 2 Ross Burton 2007-03-07 17:19:57 UTC 
Created attachment 84186 [details] [review]
Part 2

This patch also...
Comment 3 Matthew Barnes 2007-03-25 20:21:56 UTC 
Nice cleanup!  A few comments:

  * The e-name-western-tables.h patch that you committed earlier today
    introduces a small but easily correctable conflict when applying the
    first patch.  

  * Need to remove '#include "e-book-marshal.h"' from:

      addressbook/libebook/e-book-listener.c
      addressbook/libebook/e-book-view.c
      addressbook/libebook/e-book-view-listener.c

  * Need to remove '#include "e-data-book-marshal.h"' from:

      addressbook/libedata-book/e-data-book.c

  * Just a note (to self, really) that we'll want to remove some files from
    Subversion when this gets committed:

      addressbook/libebook/e-book-marshal.list
      addressbook/libedata-book/e-data-book-marshal.list
      servers/exchange/storage/e-shell-marshal.list
Comment 4 Ross Burton 2007-04-04 21:09:07 UTC 
If someone can approve this for commit I can handle the cleanup too...
Comment 5 Matthew Barnes 2007-04-04 21:17:28 UTC 
Done.
Comment 6 Ross Burton 2007-04-04 21:35:52 UTC 
Committed, thanks!