After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400702 - rhythmbox crashed with SIGSEGV in strcmp()
rhythmbox crashed with SIGSEGV in strcmp()
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
Old
Other Linux
: Normal critical
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 401424 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-25 18:02 UTC by Sebastien Bacher
Modified: 2008-06-03 17:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Description Sebastien Bacher 2007-01-25 18:02:37 UTC 
That bug has been opened on https://launchpad.net/ubuntu/+source/rhythmbox/+bug/81511

"...Rhytmbox crashed when I double-clic on a webradio...."

Debug version for the backtrace:

+ Trace 105209

  • #0 strcmp
    from /lib/tls/i686/cmov/libc.so.6
  • #1 totem_pl_parser_parse_internal
    at totem-pl-parser.c line 914
  • #2 totem_pl_parser_parse_with_base
    at totem-pl-parser.c line 1109
  • #3 totem_pl_parser_parse
    at totem-pl-parser.c line 1116
  • #0 strcmp
    from /lib/tls/i686/cmov/libc.so.6
  • #1 totem_pl_parser_parse_internal
    at totem-pl-parser.c line 1041
  • #2 test_parsing_real
    at test-parser.c line 83
  • #3 push_parser
    at test-parser.c line 111
  • #4 g_idle_dispatch
    at gmain.c line 3928 






Comment 1


Bastien Nocera





          2007-01-26 16:44:38 UTC
        



$ ./test-parser http://www.jetfm.asso.fr:9000/jetfm.mp3

###################### parsing ################

url 'http://www.jetfm.asso.fr:9000/jetfm.mp3' unhandled

Works fine here with the current totem SVN trunk.

Is the mime-type NULL? What's the output of gnomevfs-info on that stream?






Comment 2


Christian Kirbach





          2007-01-27 21:27:33 UTC
        



*** Bug 401424 has been marked as a duplicate of this bug. ***






Comment 3


Christian Kirbach





          2007-01-27 21:29:46 UTC
        



last dup has an excellent trace

mimetype = 0x0

ret = TOTEM_PL_PARSER_RESULT_ERROR

the report says that the file was moved meanwhile (while playing?after opening? while opening?).






+
Trace
    105778






    

  • 
#2
<signal handler called>

    • 

  • 
#3
strcmp

    
                from
                /lib/tls/libc.so.6

    

    • 

  • 
#4
totem_pl_parser_parse_internal

    
                at totem-pl-parser.c
                  line
                  1041

    

    • 

  • 
#5
totem_pl_parser_parse_with_base

    
                at totem-pl-parser.c
                  line
                  1109

    

    • 

  • 
#6
totem_pl_parser_parse

    
                at totem-pl-parser.c
                  line
                  1116

    

    • 

  • 
#7
totem_playlist_add_mrl

    
                at totem-playlist.c
                  line
                  1645

    

    • 

  • 
#8
on_recent_file_item_activated

    
                at totem-menu.c
                  line
                  438

    

    • 













Comment 4


Sebastien Bacher





          2007-01-28 10:03:13 UTC
        



$ gnomevfs-info http://www.jetfm.asso.fr:9000/jetfm.mp3
Error: Unsupported operation






Comment 5


Sebastien Bacher





          2007-01-28 15:06:16 UTC
        



today test-plparser doesn't crash neither using the same version, the server side has probably changed






Comment 6


Bastien Nocera





          2007-01-29 00:16:21 UTC
        



That would be the problem:
        if (strcmp (mimetype, AUDIO_MPEG_TYPE) == 0 && parser->priv->recurse_level == 0 && data == NULL) {
                g_free (mimetype);
                mimetype = my_gnome_vfs_get_mime_type_with_data (url, &data, parser);
                DEBUG(g_print ("_get_mime_type_with_data for '%s' returned '%s' (was %s)\n", url, mimetype ? mimetype : "NULL", AUDIO_MPEG_TYPE));
        }

We don't check the return value of my_gnome_vfs_get_mime_type_with_data()...






Comment 7


Bastien Nocera





          2007-01-29 00:26:41 UTC
        



2007-01-29  Bastien Nocera  <hadess@hadess.net>

        * src/plparse/Makefile.am:
        * src/plparse/plparser.symbols:
        * src/plparse/test-parser.c: (main):
        * src/plparse/totem-pl-parser-private.h:
        * src/plparse/totem-pl-parser.c: (totem_pl_parser_add_url_valist),
        (totem_pl_parser_add_one_url), (totem_pl_resolve_url),
        (totem_pl_parser_parse_internal): Only export public symbols in the
        library to avoid the symbol-snatchers, const a few functions as
        required, return an error when there was an error parsing,
        Avoid crashes when the filename tells us it's an MP3, but we can't
        verify it (Closes: #400702)







Comment 8


Philip Withnall





          2008-06-03 17:39:57 UTC
        



Mass-move from totem to totem-pl-parser. You can remove all messages by searching for this comment.