After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400656 - [PATCH] filesrc seekability detection fix (NFS and 2GB+ files)
[PATCH] filesrc seekability detection fix (NFS and 2GB+ files)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.12
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-25 16:12 UTC by Jindrich Makovicka
Modified: 2007-01-25 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Seekability detection fix for NFS and 2GB+ files. (643 bytes, patch)
2007-01-25 16:13 UTC, Jindrich Makovicka 		committed Details | Review

Description Jindrich Makovicka 2007-01-25 16:12:18 UTC 
With the current version of filesrc, files larger than 2 gigabytes on NFS are considered seekable, even if the seeking beyond 2GB boundary is actually impossible. This can cause the pipeline fail later.

The attached patch modifies filesrc.c to test the seekability by seeking to the end of the file.
Comment 1 Jindrich Makovicka 2007-01-25 16:13:52 UTC 
Created attachment 81204 [details] [review]
Seekability detection fix for NFS and 2GB+ files.
Comment 2 Sebastian Dröge (slomo) 2007-01-25 18:06:34 UTC 
Thanks, committed:

2007-01-25  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Jindrich Makovicka <jindrich.makovick at itonis dot tv>

        * plugins/elements/gstfilesrc.c: (gst_file_src_start):
        If not using mmap'ed files try to seek to the end instead of the
        start to determine whether we can seek at all. This fixes the case
        of 2GB+ files over NFS, where seeks in the first 2GB can succeed but
        seeks for everything afterwards fail. Fixes #400656