After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400498 - can't adjust the volume with the scrollwheel
can't adjust the volume with the scrollwheel
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
2.17.x
Other Linux
: Normal normal
: 2.17.91
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-25 04:43 UTC by Claudio Saavedra
Modified: 2007-02-06 16:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
fix the problem by not using an int value (649 bytes, patch)
2007-02-03 12:59 UTC, Sebastien Bacher
committed Details | Review

Description Claudio Saavedra 2007-01-25 04:43:25 UTC
It used to be possible to adjust any of the volume levels in the g-v-c using the scrollwheel. In 2.17.90, it's no longer possible.
Comment 1 Ronald Bultje 2007-01-25 13:06:07 UTC
Works for me... Any chance your gtk was updated or your mousewheel configuration broke or so?
Comment 2 Claudio Saavedra 2007-01-25 20:24:30 UTC
I'm testing with current svn versions targeted to GNOME 2.18. I just updated gnome-media and gtk+, and the problem is still there.
Comment 3 Ronald Bultje 2007-01-25 23:33:03 UTC
Well, yes, but that doesn't help me any further than the original bug report. :-). Could you please downgrade gtk while keeping gnome-media at svn and the other way around to confirm which one causes the issue?

Again, gnome-media svn + gtk 2.8 has no issues for me.
Comment 4 Claudio Saavedra 2007-01-25 23:41:34 UTC
(In reply to comment #3)
> Again, gnome-media svn + gtk 2.8 has no issues for me.
> 

The GTK+ targeted version is 2.10.x, as far as jhbuild tells me. I'll downgrade when I have the time.
Comment 5 Ronald Bultje 2007-01-26 00:40:58 UTC
It works with 2.8 as well, but gnome-cd (I think) won't be compiled in.

So, yes, I'm currently not doing any work on gnome-cd because it doesn't build here. :-).
Comment 6 Sebastien Bacher 2007-02-02 18:10:46 UTC
Ubuntu bug about that: https://launchpad.net/gnome-media/+bug/82737

"Mouse scroll wheel doesn't control volume sliders

Binary package hint: gnome-media

This is a regression - it worked in Edgy but does not in Feisty.

The mouse wheel on my mouse does not scroll the volume sliders in gnome-volume-control up and down. It correctly scrolls sliders in other places in the system - the gnome volume applet or mouse settings applet in control center.

If I can provide any further information to diagnose this please let me know."


I can confirm it's broken for gnome-volume-control, that's not likely to be a GTK bug because it works with the mixer applet by example
Comment 7 Ronald Bultje 2007-02-02 18:37:15 UTC
I still cannot reproduce. You guys will need to help me here. I need someone to test the versions as per above to give me an indication of what causes the bug, for example. Again, I cannot reproduce, and since I can't reproduce, I won't be able to fix it, no matter how much I want to.
Comment 8 Chris Rose 2007-02-02 19:16:21 UTC
I reported this bug on launchpad. If you can guide me to some information about what I can do to help find this bug I am more than happy to help.
Comment 9 Ronald Bultje 2007-02-02 20:05:57 UTC
Force-install gtk 2.8 over gtk 2.10 (eg. the edgy version of gtk), start g-v-c and let me know if the scroll button works. Then reinstall gtk 2.10 again over 2.8 to get your old system back.
Comment 10 Chris Rose 2007-02-02 23:34:38 UTC
Sorry I think I'm missing something here. Edgy appears to use 2.10 aswell as feisty:

http://packages.ubuntu.com/edgy/libs/libgtk2.0-0

http://packages.ubuntu.com/feisty/libs/libgtk2.0-0

If this is the right package please let me know and I'll revert to the edgy package and see if it works.
Comment 11 Ronald Bultje 2007-02-03 03:39:31 UTC
I guess so... Just as long as someone can confirm that _either_ gnome-media alone _or_ gtk alone version change causes this bug, not an upgrade of both. :-).
Comment 12 Chris Rose 2007-02-03 10:20:00 UTC
Unfortunatly reverting gnome-media alone down to 2.16.1 makes the mouse scroll wheel work again. I diff'd the changes but I can't see anything that would cause it.
Comment 13 Sebastien Bacher 2007-02-03 12:10:57 UTC
Reverting that commit fixes the problem:
http://svn.gnome.org/viewcvs/gnome-media/trunk/gst-mixer/src/volume.c?rev=3492&r1=3186&r2=3492
Comment 14 Sebastien Bacher 2007-02-03 12:59:15 UTC
Created attachment 81814 [details] [review]
fix the problem by not using an int value

the adjustment values are gdouble ones and you are using ints, adding .0 makes it work fine on my feisty desktop
Comment 15 Ronald Bultje 2007-02-03 15:26:54 UTC
http://svn.gnome.org/viewcvs/gnome-media/trunk/gst-mixer/src/volume.c?rev=3492&r1=3186&r2=3492

Could you revert that patch and tell me if it fixes it? If it doesn, could you tell me (using printf) your min and max volume? Could you also check whether changing the "(vol->track->max_volume - vol->track->min_volume) / 100" (and/or the / 10 on the next line) to "MAX((vol->track->max_volume - vol->track->min_volume) / 100, 1.0)" or to "(vol->track->max_volume - vol->track->min_volume) / 100.0" fixes this bug?
Comment 16 Sebastien Bacher 2007-02-03 16:15:33 UTC
did you read my previous comments? 

"Reverting that commit fixes the problem:
http://svn.gnome.org/viewcvs/gnome-media/trunk/gst-mixer/src/volume.c?rev=3492&r1=3186&r2=3492"

and did you look at my proposed patch?
Comment 17 Ronald Bultje 2007-02-03 17:05:04 UTC
Either I'm blind, or your comments weren't actually there when I added my comment (honestly!). Anyway, thanks for looking into it, please commit.
Comment 18 Sebastien Bacher 2007-02-06 16:03:54 UTC
No problem, patch commited:

2007-02-06  Sebastien Bacher  <seb128@ubuntu.com>

	* gst-mixer/src/volume.c: (get_scale):
	- don't use int values for gtk_adjustment_new (), fix scrollwheel 
	  not working to adjust the volume (Closes: #400498)