GNOME Bugzilla – Bug 400106
Improve fullscreen control overlay positioning
Last modified: 2008-05-04 12:34:52 UTC
The position of the fullscreen control overlay looks a bit too heigh to me. Also, i'd rather not see the overlay popup every time I move the mouse. The attached patch fixes both by 1. drawing the controls a bit lower 2. only show the control box when the mouse moves in its direction.
Created attachment 81041 [details] [review] Fix a bit what bothers me about the otherwise marvellous fullscreen control box
Created attachment 81989 [details] [review] same as original, but moves the box to the bottom, keeps it around for a shorter time, and doesn't display it when you navigate in fullscreen with the keyboard has not been thoroughly tested
for some reason this didn't show up in the above, but thanks for your patch, Thomas.
I like this patch, although I wouldn't round the bottom corners if the toolbar sits at the complete bottom of the screen. I don't mind the placement of the current floating toolbar, but it does get in the way when showing pictures in fullscreen.
Great patch. Works with me for current svn head, and looks relatively clean - although I'd suggest actually removing the code rather than just commenting it out. my only complaint is that the dialog still shows up when the mouse button is pressed to pan around a zoomed-in image.
fixed in r3865, no longer draw rounded corners on the sides