After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400106 - Improve fullscreen control overlay positioning
Improve fullscreen control overlay positioning
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-24 06:54 UTC by Thomas Van Machelen
Modified: 2008-05-04 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix a bit what bothers me about the otherwise marvellous fullscreen control box (1.42 KB, patch)
2007-01-24 06:54 UTC, Thomas Van Machelen
committed Details | Review
same as original, but moves the box to the bottom, keeps it around for a shorter time, and doesn't display it when you navigate in fullscreen with the keyboard (1.69 KB, patch)
2007-02-06 10:40 UTC, Paul Ivanov
none Details | Review

Description Thomas Van Machelen 2007-01-24 06:54:08 UTC
The position of the fullscreen control overlay looks a bit too heigh to me.  Also, i'd rather not see the overlay popup every time I move the mouse.

The attached patch fixes both by 
1. drawing the controls a bit lower
2. only show the control box when the mouse moves in its direction.
Comment 1 Thomas Van Machelen 2007-01-24 06:54:52 UTC
Created attachment 81041 [details] [review]
Fix a bit what bothers me about the otherwise marvellous fullscreen control box
Comment 2 Paul Ivanov 2007-02-06 10:40:37 UTC
Created attachment 81989 [details] [review]
same as original, but moves the box to the bottom, keeps it around for a shorter time, and doesn't display it when you navigate in fullscreen with the keyboard

has not been thoroughly tested
Comment 3 Paul Ivanov 2007-02-06 10:42:25 UTC
for some reason this didn't show up in the above, but thanks for your patch, Thomas.
Comment 4 Jakub Steiner 2007-02-25 19:08:28 UTC
I like this patch, although I wouldn't round the bottom corners if the toolbar sits at the complete bottom of the screen.

I don't mind the placement of the current floating toolbar, but it does get in the way when showing pictures in fullscreen.
Comment 5 wjbaird 2007-04-05 19:47:08 UTC
Great patch.    Works with me for current svn head, and looks relatively clean - although I'd suggest actually removing the code rather than just commenting it out.

my only complaint is that the dialog still shows up when the mouse button is pressed to pan around a zoomed-in image.
Comment 6 Stephane Delcroix 2008-05-04 12:34:52 UTC
fixed in r3865, no longer draw rounded corners on the sides