After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 399373 - missing pixel in rendering rounded corners (all themes)
missing pixel in rendering rounded corners (all themes)
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: themes
2.17.x
Other Linux
: Normal minor
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-01-22 13:23 UTC by Jakub Steiner
Modified: 2007-04-09 02:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
missing pixel in the rounded corner rendering (gilouche) (6.00 KB, image/png)
2007-01-22 13:23 UTC, Jakub Steiner 		  Details
same error on clearlooks (2.12 KB, image/png)
2007-01-22 13:24 UTC, Jakub Steiner 		  Details
and yet again, missing pixel (4.19 KB, image/png)
2007-01-22 13:24 UTC, Jakub Steiner 		  Details
Round corners in gnumeric (4.11 KB, application/x-gnumeric)
2007-02-17 23:20 UTC, Arthur Taylor 		  Details
New method or rounding corners. (2.94 KB, patch)
2007-02-17 23:23 UTC, Arthur Taylor 		committed Details | Review

Description Jakub Steiner 2007-01-22 13:23:22 UTC 
The 2.17 metacity seems to have introduced a misrendering of the old style themes which have rounded corners. Attached are some zoomed screenshots exposing the misrendering. It appears on all themes with rounded corners I have tested.
Comment 1 Jakub Steiner 2007-01-22 13:23:52 UTC 
Created attachment 80888 [details]
missing pixel in the rounded corner rendering (gilouche)
Comment 2 Jakub Steiner 2007-01-22 13:24:09 UTC 
Created attachment 80889 [details]
same error on clearlooks
Comment 3 Jakub Steiner 2007-01-22 13:24:30 UTC 
Created attachment 80890 [details]
and yet again, missing pixel
Comment 4 Thomas Thurman 2007-01-22 13:29:18 UTC 
Oh, goodness, yes. Elijah found this problem in bug 360542 comment 9. I think we should adopt the fudge he specified in that comment to fix this.
Comment 5 Sebastien Bacher 2007-02-11 19:42:55 UTC 
Ubuntu bug about that: https://launchpad.net/ubuntu/+source/metacity/+bug/83847
Comment 6 Arthur Taylor 2007-02-17 23:20:55 UTC 
Created attachment 82765 [details]
Round corners in gnumeric

Demonstration of a possible better corner rendering method.
Comment 7 Arthur Taylor 2007-02-17 23:23:55 UTC 
Created attachment 82767 [details] [review]
New method or rounding corners.

Implements what was demonstrated in the gnumeric file.
Comment 8 Arthur Taylor 2007-03-06 20:50:56 UTC 
Also, the bottom rounded corners code contains an off by one error:

-          xrect.y = new_window_height - i;
+          xrect.y = new_window_height - i - 1;
Comment 9 Alexander “weej” Jones 2007-03-18 02:21:15 UTC 
Current broken code is in GNOME 2.18, and in Ubuntu 7.04. Makes GNOME and Ubuntu look bad. :(
Comment 10 Thomas Thurman 2007-03-18 02:24:36 UTC 
Maybe I should move this up to the top of my work queue.
Comment 11 Thomas Thurman 2007-03-21 02:27:08 UTC 
Arthur: a winner is you. Committed, and fixed.
Comment 12 Sebastien Bacher 2007-04-08 15:00:58 UTC 
any reason the change has not been commited to the 2.18.1 version?
Comment 13 Thomas Thurman 2007-04-09 02:12:12 UTC 
It will be in 2.18.2.