After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 399238 - The buttons in left pane of gnome-control-center should have labels and descriptions.
The buttons in left pane of gnome-control-center should have labels and descr...
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other All
: Normal major
: ---
Assigned To: Scott Reeves
GNOME main menu maintainers
: 396544 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-22 03:27 UTC by Tim Miao
Modified: 2007-02-22 11:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Add accessible names and descs to grouping buttons (922 bytes, patch)
2007-01-29 07:42 UTC, Patrick Wade
none Details | Review
Add accessible names to the grouping buttons (833 bytes, patch)
2007-02-02 11:02 UTC, Patrick Wade
none Details | Review
new a11y patch (732 bytes, patch)
2007-02-21 21:54 UTC, Scott Reeves
none Details | Review

Description Tim Miao 2007-01-22 03:27:06 UTC
Please describe the problem:
This is the accessibility bug for gnome-control-center.

Steps to reproduce:
1. Launch gnome-control-center and orca.
2. Press Tab to move focus onto the group button, say Hardware, Internet and Network and etc.
3. Invoke at-poke, track the buttons in the left pane of gnome-control-center.


Actual results:
The buttons have no label and descriptions, so that the screen reader fail to read these buttons.

Expected results:
The buttons should be read by screen reader(orca).

Does this happen every time?
Yes.

Other information:
This bug can be found with gnome2.17.5.
Comment 1 Thomas Wood 2007-01-22 08:31:49 UTC
This will be an issue with libslab, which is responsible for creating the window and widgets.
Comment 2 Patrick Wade 2007-01-29 07:42:47 UTC
Created attachment 81408 [details] [review]
Add accessible names and descs to grouping buttons
Comment 3 Patrick Wade 2007-02-02 11:02:49 UTC
Created attachment 81746 [details] [review]
Add accessible names to the grouping buttons

Rework of the patch, minus the descriptions (can be done after Gnome2.18 instead).
Comment 4 Patrick Wade 2007-02-02 13:23:05 UTC
*** Bug 396544 has been marked as a duplicate of this bug. ***
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-02-06 23:02:42 UTC
I just tried the reworked patch.  Works great!  Thanks!!
Comment 6 Denis Washington 2007-02-19 18:50:30 UTC
Scott, could you look at this patch? It seems to be very important for a11y.
Comment 7 Scott Reeves 2007-02-21 21:54:40 UTC
Created attachment 83071 [details] [review]
new a11y patch

According to my limited understanding of a11y this call only needs to be made once on each widgets accessible object, correct?  So we can make this call in the creation of the widget, not in the populate_groups_section method, which gets called repeatedly every time the filter changes.

Does this new patch work for you?
Comment 8 Joanmarie Diggs (IRC: joanie) 2007-02-21 22:31:09 UTC
Hi Scott.  This patch *mostly* works for me.  It definitely solves the original problem (i.e. access to the Groups buttons).  Thanks!!

Since then, however, a Common Tasks section has shown up below Groups.  :-)  if you could do the same thing for the buttons in the Common Tasks section I think we'll be set.
Comment 9 Scott Reeves 2007-02-22 00:50:29 UTC
Added the code to set the "Common Tasks" buttons. Committing to svn.
Comment 10 Patrick Wade 2007-02-22 11:09:14 UTC
(In reply to comment #7)
> According to my limited understanding of a11y this call only needs to be made
> once on each widgets accessible object, correct?  So we can make this call in
> the creation of the widget, not in the populate_groups_section method, which
> gets called repeatedly every time the filter changes.

Correct Scott.