After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398278 - Banshee rips with different settings than preference
Banshee rips with different settings than preference
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
0.11.2
Other Linux
: Normal major
: 0.13.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 400123 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-19 06:43 UTC by Kaiwai Gardiner
Modified: 2007-10-23 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
load cd-importing gconf key at rip time (577 bytes, patch)
2007-10-06 08:33 UTC, Wade Menard
none Details | Review

Description Kaiwai Gardiner 2007-01-19 06:43:40 UTC
When Helix Banshee 0.11.2 crashes on OpenSuSE, when one reopens Banshee, and imports a cd, although the setting in ogg is set to 6, it rips at quality level 5.

One has to open up the preferences option, manually put the slide back to 5, press close, and close, then open up the preferences again and select 6 from the slide selector.

The normal behaviour should be that the setting originally set should be retained, irrespective of whether the application has crashed or not.
Comment 1 Kaiwai Gardiner 2007-01-20 03:40:58 UTC
I've since noticed that the application settings are lost even on a normal exit of the application; I set the setting to quality '6' but when I exit and reload, to rip it goes back to ripping at 160kbps rather than 192kbps; 160kbps being quality level 5, and the default setting.
Comment 2 Martey Dodoo 2007-05-29 19:59:13 UTC
This behavior was also seen in Ubuntu: https://bugs.launchpad.net/banshee/+bug/105059
Comment 3 Gabriel Burt 2007-06-21 22:59:33 UTC
*** Bug 400123 has been marked as a duplicate of this bug. ***
Comment 4 Gabriel Burt 2007-06-21 23:04:10 UTC
I'm doubtful this has anything to do with crashing, since the settings should be saved via GConf immediately.  If you want to help us debug this, you can run through the steps to reproduce this again, but have the Configuration Editor (Applications -> System Tools) open, find the relevant entry (search for banshee), and watch the values at each step of the way.
Comment 5 Martey Dodoo 2007-08-08 07:19:11 UTC
I think that Banshee is either not initially reading the ripping settings, or is not passing them correctly. Using latest SVN trunk, I ripped a CD, which was imported as 128 kbps CBR MP3. I opened the preferences dialog, confirmed that my settings were 192 kbps CBR MP3 (set during a previous run of the application), ejected the CD, and then began ripping it again. It now rips into 192 kbps files.
Comment 6 Jamie 2007-08-23 21:42:59 UTC
I updated from 0.10.9 to 0.13.1. Under .10.9, importing a CD to FLAC format files works fine. Under .13.1, FLAC is set as the desired output format in the
Preferences dialog, but the import actually generates 160 kbs Ogg format files.


Comment 7 Martey Dodoo 2007-09-12 01:32:03 UTC
Just for kicks, I just burned a CD with the Configuration Editor open (set to be Always on Top). The first time, it burnt as a 128 kbps MP3, while "/apps/banshee/audio_profiles/cd-importing/lame-mp3/bitrate" was still set to 192. I stopped the import, opened the Preferences dialog and then closed it, and the CD then burnt as 192 kbps MP3s.
Comment 8 Wade Menard 2007-10-06 08:33:30 UTC
Created attachment 96744 [details] [review]
load cd-importing gconf key at rip time

Ok this was getting awfully annoying for me lately with my large influx of CDs.

I did some digging and found that the only time Banshee.AudioProfiles.LoadConfiguration("cd-importing") was being called (which loads the relevant cd-importing key from GConf) was when the edit output format dialog was opened. No tweaking of the pipeline needed, just open and close.

My solution was to add a call to this from Banshee.Base.AudioCdRipper. I'll leave it to someone more knowledgeable with the profile configuration to decide if the call should be done elsewhere. I was thinking of doing it in Globals.cs after the pipeline tests but didn't see the need to add another ProfileConfiguration object there. Though the key reading would only have to be done once instead of every time a CD import is started.
Comment 9 Gabriel Burt 2007-10-23 20:29:39 UTC
Fixed (in stable branch, for now).  The same issue affected dap transcoding.