After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 397810 - [typefinding] .vob file: could not determine type of stream
[typefinding] .vob file: could not determine type of stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.11
Other Linux
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-17 23:04 UTC by Sven Arvidsson
Modified: 2007-01-19 12:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
possible fix: makes mpeg2 system stream typefinder probe a bit into the file (2.17 KB, patch)
2007-01-18 12:10 UTC, Tim-Philipp Müller
none Details | Review

Description Sven Arvidsson 2007-01-17 23:04:56 UTC
The attached file fails to play using playbin (and Totem) with this error message "Could not determine type of stream". Forcing playback in a pipeline with mpeg2dec works fine.

The file in question is a VOB file, and could possibly be corrupt or at least faulty as "file" only can detect it as "data".
Comment 1 Sven Arvidsson 2007-01-17 23:11:24 UTC
The faulty video file:
http://www.whiz.se/temp/397810.vob
Comment 2 Tim-Philipp Müller 2007-01-18 12:10:35 UTC
Created attachment 80583 [details] [review]
possible fix: makes mpeg2 system stream typefinder probe a bit into the file
Comment 3 Jan Schmidt 2007-01-19 00:40:48 UTC
I've had this in the back of my head to do for a while. The implementation looks OKish. Not sure if making 4KB the new minimum size for MPEG files will be important.
Comment 4 Tim-Philipp Müller 2007-01-19 12:24:30 UTC
Admittedly the implementation is a bit crude, but it's better than doing a new peek for each offset. I suppose you had something a bit more sophisticated in mind like what we're doing for mpeg1?

I've committed this for now, but changed it to accept smaller sizes as well: 21 bytes is the new minimum size now, I think that should be fine even for buffer/push-mode based typefinding. 

  2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
          Small mpeg2 system stream typefinding improvement: make typefinder
          probe a bit into the stream instead of just looking for a marker
          at the beginning. Fixes #397810.

I guess the main worry are potential false positives, but since we're using such a low probability when suggesting the caps, almost all other typefinders should trump us, at least after this follow-up:

  2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
          Lower probability a bit if the marker isn't right at the start,
          to decrease the chance of false positives.

Feel free to replace with something better when you get around to it :)