After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 397310 - Provide a Tango style application icon for Menus & Toolbars capplet
Provide a Tango style application icon for Menus & Toolbars capplet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
git master
Other All
: Normal normal
: ---
Assigned To: Rodrigo Moya
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-16 16:49 UTC by Luca Ferretti
Modified: 2007-02-16 22:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposal (1.80 KB, image/png)
2007-01-20 01:03 UTC, Andreas Nilsson
Details
gnome-ui-properties in all sizes (7.98 KB, application/x-gzip)
2007-01-22 01:06 UTC, Andreas Nilsson
Details
UI properties icon in all sizes (12.30 KB, application/x-bzip)
2007-02-16 21:15 UTC, Jakub Steiner
Details

Description Luca Ferretti 2007-01-16 16:49:01 UTC
The current icon for Menus & Toolbars capplet in control center is using wrong style (old GNOME instead new Tango).

Maybe we should also change its name and use the same name of the executable or
something like "preferences-desktop-menu-toolbars" (see Icon Naming Spec).

PS of course I know this capplet shoulb be merged with Theme...
Comment 1 Andreas Nilsson 2007-01-20 00:25:20 UTC
I want to sign up for this one.
Comment 2 Andreas Nilsson 2007-01-20 01:03:39 UTC
Created attachment 80744 [details]
Proposal

Would this do?
It's just the old icon updated to the style guidelines, as I guess we're only going to keep this for one release anyway...
Comment 3 Thomas Wood 2007-01-20 09:26:22 UTC
Looks good to me.
Comment 4 Jakub Steiner 2007-01-20 18:34:21 UTC
Works for me too.
Comment 5 Andreas Nilsson 2007-01-22 01:06:05 UTC
Created attachment 80849 [details]
gnome-ui-properties in all sizes

Called it the same as the app as it felt easiest.
Comment 6 Rodrigo Moya 2007-01-24 12:31:29 UTC
Would it be too much asking that you provide a patch with the needed Makefile.am's? Or just tell me another module to look at for examples on where I need to copy the files?
Comment 7 Luca Ferretti 2007-01-24 12:52:36 UTC
(In reply to comment #6)
> Would it be too much asking that you provide a patch with the needed
> Makefile.am's? Or just tell me another module to look at for examples on where
> I need to copy the files?
> 

I suggest you to create a directory tree like:

    data +
         +-> icons +
                   +--> 16x16 +
                   |          +--> apps
                   |
                   +--> 22x22 +
                   |          +--> apps
                   |
                   +--> 24x24 +
                   |          +--> apps
                   |
                   +--> 32x32 +
                   |          +--> apps
                   |
                   +--> scalable +
                                 +--> apps

Then put icons in proper directory (24x24 is just 22x22 converted using `convert -bordercolor Transparent -border 1x1  22.png 24.png"

For Makefile.am files see eog
1. http://svn.gnome.org/viewcvs/*checkout*/eog/trunk/data/icons/16x16/apps/Makefile.am?rev=3420
2. http://svn.gnome.org/viewcvs/*checkout*/eog/trunk/data/icons/Makefile.am?rev=3420

About data/icons/Makefile.am, note that gtk-update-icon-cache is not needed if you will install icons in $prefix/share/icons/gnome

PS I'm suggesting this "deep" scheme instead a "flat" scheme in each capplet subdirectory to be ready when capplets will need their own named icons: then you could simply add data/icons/<size>/<category>/directory. A single place to manage icons.
Comment 8 Rodney Dawes 2007-01-24 15:20:29 UTC
DO NOT EVER INSTALL ICONS TO A THEME OTHER THAN HICOLOR.

Also, do not install generic named icons to hicolor, or anything other than the main app icon that will be used for the desktop launcher, to the system hicolor theme.
Comment 9 Rodrigo Moya 2007-01-25 10:14:01 UTC
Rodney, could you please provide the correct Makefile.am files? As suggested by Luca, we want a data/ directory in the top-level of control-center, instead of having that for each capplet.
Comment 10 Hylke Bons 2007-02-15 16:19:55 UTC
I'd get rid of the text.
Comment 11 Jakub Steiner 2007-02-16 21:15:30 UTC
Created attachment 82700 [details]
UI properties icon in all sizes

Here's the icon without the text labels and I think a bit cleaner
Comment 12 Jakub Steiner 2007-02-16 22:23:20 UTC
Went in gnome-icon-theme.