GNOME Bugzilla – Bug 397010
Add Jamendo plugin
Last modified: 2007-01-31 23:00:13 UTC
As announced on the mailing list [1], I wrote a Jamendo plugin. You can get it using bazaar: bzr branch http://cass.no-ip.com/~cassidy/repos/jamendo/ Or apply the patch following. [1] http://mail.gnome.org/archives/rhythmbox-devel/2007-January/msg00051.html
Created attachment 80332 [details] [review] Jamendo plugin
Created attachment 80333 [details] images
Works great for me. A suggestion for the plugin: enhance the cover art plugin so that it pulls the image from the internal cover art database, which I see contains URLs to the cover art, rather than attempting an Amazon search (as is done for the library). Somebody enhanced the podcast source to do just that, see bug #380746. <album validationURL="http://www.perrocker.com/discografia/yosoy.htm" publicDate="2004-07-13" archiveSet="2" popularity="0.555555555556" releaseDate="200 6-11-10 00:07:38" artistID="3180" link="http://www.jamendo.com/album/3278/" id="3278"> <dispname>Yo Soy</dispname> <genre>Pop-Rock</genre> <description/> <tags/> <Covers> <cover res="0" no="1">http://img.jamendo.com/albums/3278/covers/1.0.jpg</cover> <cover res="100" no="1">http://img.jamendo.com/albums/3278/covers/1.100.jpg</cover> <cover res="300" no="1">http://img.jamendo.com/albums/3278/covers/1.300.jpg</cover> <cover res="500" no="1">http://img.jamendo.com/albums/3278/covers/1.500.jpg</cover> </Covers> <P2PLinks> <p2plink audioEncoding="mp32" network="ed2k">http://www.jamendo.com/get/album/id/album/p2p/redirect/3278/?p2pnet=ed2k&are=mp32</p2plink> <p2plink audioEncoding="mp32" network="bittorrent">http://www.jamendo.com/get/album/id/album/p2p/redirect/3278/?p2pnet=bittorrent&are=mp32</p2pli nk> <p2plink audioEncoding="ogg3" network="ed2k">http://www.jamendo.com/get/album/id/album/p2p/redirect/3278/?p2pnet=ed2k&are=ogg3</p2plink> <p2plink audioEncoding="ogg3" network="bittorrent">http://www.jamendo.com/get/album/id/album/p2p/redirect/3278/?p2pnet=bittorrent&are=ogg3</p2pli nk> </P2PLinks> </album
Yes, it's on my TODO list but I think we could add it later after.
In fact, I'd prefer to see this first version commited upstream (if it's possible) and then start the work for the covers stuff (to avoid to handle big patchs on a lot of files).
Guillaume: I love you.
Cass > You are my hero !
Created attachment 80702 [details] [review] updated patch This version display the browser if needed (see bug 390834). I opened bug 398384 for the covers. I think this version is ready for inclusion. You can get it using this patch and the images tarball or from my bazaar branch. bzr branch http://cass.no-ip.com/~cassidy/repos/jamendo/
Created attachment 81191 [details] [review] add cover support This updated patch add support for the cover art plugin (fix bug 398384).
Created attachment 81198 [details] Add release date support Taken from the magnatune plugin, uses the album "releaseDate" attribute to get the Year for the rhythmbox interface. Btw, I also tested the cover art image support in the latest patch, seems to work well.
Committed to svn. Thanks for your work on this.