After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 396436 - properties view order changes with locale
properties view order changes with locale
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: user interface
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-14 13:53 UTC by Christian Persch
Modified: 2007-03-06 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1011 bytes, patch)
2007-03-03 21:49 UTC, Christian Persch
none Details | Review
Posible fix (1.79 KB, patch)
2007-03-06 18:52 UTC, Juan Pablo Ugarte
none Details | Review

Description Christian Persch 2007-01-14 13:53:41 UTC
Steps to reproduce:
0) LANGUAGE=en glade-3 some-file.glade
1) Look at some widget's properties
2) LANGUAGE=fr glade-3 some-file.glade
3) Look at some widget's properties

Results:
The properties order is changed between steps 1 and 3. I'd expect instead a stable order independent of locale.
Comment 1 Christian Persch 2007-03-03 21:49:41 UTC
Created attachment 83845 [details] [review]
proposed patch

Apply this patch in addition to xjuan's patch.

The problem was in glade_editor_property_class_comp: it appears the pspec->owner_type values vary with the locale!

This patch seems to fix the problem. I don't know whether the g_assert_not_reached() is correct here; can this case happen?
Comment 2 Juan Pablo Ugarte 2007-03-06 18:52:32 UTC
Created attachment 84109 [details] [review]
Posible fix

Please, give this patch a try and let me know if its works for you.
Comment 3 Tristan Van Berkom 2007-03-06 19:50:09 UTC
Juan, please commit as we discussed on irc, chpe's fix
with your flavour without the assertion.

I sorted everything out and we're branched, so please commit
to trunk and we're going to start managing a list of bugfixes
pending merge approval from the release-team (this will be the
first bug on the list... at home I'll commit the accelerators/
atk props to trunk and throw that on the list too).

And please mark this bug fixed even if its not on the 2.18
branch yet.
Comment 4 Juan Pablo Ugarte 2007-03-06 21:55:27 UTC
ok, committed in trunk