After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395927 - Move Cancel button to status bar?
Move Cancel button to status bar?
Status: RESOLVED NOTGNOME
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-01-12 21:55 UTC by Matthew Barnes
Modified: 2013-09-13 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (176.26 KB, image/png)
2007-01-12 21:58 UTC, Matthew Barnes
  Details
Proposed patch (7.56 KB, patch)
2007-01-12 21:59 UTC, Matthew Barnes
none Details | Review
Revised patch (13.95 KB, patch)
2007-01-13 14:21 UTC, Matthew Barnes
none Details | Review

Description Matthew Barnes 2007-01-12 21:55:25 UTC
This is just an idea I was playing around with today.  I'm not a UI designer so I'm not sure if it's a good one, but it works.

I added a small cancel button to the ETaskBar widget that emits a "cancel" signal when clicked.  It appears on the right side of the status bar when a new task is added, and disappears after all tasks are removed.

The intent was to replace the Cancel button in the mailer's toolbar.

I see a few advantages with this approach:

  - The cancel button is placed closer to the thing that you're cancelling
    (at least as the UI represents it), rather than on the opposite side of
    the window.

  - The cancel button is only visible when there's something to cancel.

  - It frees up some space on the mailer's toolbar.
Comment 1 Matthew Barnes 2007-01-12 21:58:43 UTC
Created attachment 80146 [details]
Screenshot

Cancel button has moved from the toolbar to the lower right corner of the window, next to the operation to cancel.
Comment 2 Matthew Barnes 2007-01-12 21:59:40 UTC
Created attachment 80147 [details] [review]
Proposed patch
Comment 3 Matthew Barnes 2007-01-13 14:21:27 UTC
Created attachment 80181 [details] [review]
Revised patch

Other components that use ETaskBar may not want to display a cancel button, so this revision adds an "enable-cancel-button" property that defaults to FALSE.  Also cleaned up the code a bit, and added a finalize() method to the widget.
Comment 4 Gilles Dartiguelongue 2007-02-22 19:33:18 UTC
hum, this patch crashed on me with 2.9.91.
Comment 5 Matthew Barnes 2007-02-22 20:45:43 UTC
Seems to be working okay for me from a fresh Subversion build.

Can you post a backtrace?
Comment 6 Gilles Dartiguelongue 2007-02-22 21:09:55 UTC
will do after fosdem, I recompiled to test other patches and it takes a while for me to build :)
Comment 7 Christof Krüger 2007-03-16 18:19:32 UTC
I'm not quite sure if this is a good idea. With high screen resolution and maximized evolution window, the cancel button is kind of lost down there in the corner. I would rather suggest to put it on the left side, next to the disconnect-button.
Comment 8 Srinivasa Ragavan 2007-03-16 19:04:53 UTC
Matthew, I had floated a similiar idea on e-h during the early 2.10 cycle, in lines for fixing the intrusive error dialogs. It adds the 'x' button to each tasks. Does this add 'x' to each tasks? I feel this is the way to go. In case of error, keep a '!' and a prelit/inverse the color to indicate a error in the task.
Comment 9 Matthew Barnes 2007-03-16 19:50:39 UTC
I think I remember you mentioning that.

No, this isn't that sophisticated (see the screenshot in comment #1).  I was just playing around with moving the current toolbar's Cancel button down to the status bar, so there's a stronger correspondence between the Cancel button and what the button cancels.  The behavior of the button is exactly the same.  And it's also only visible when there's an active task.
Comment 10 Matthew Barnes 2007-03-20 10:40:55 UTC
Srini, I'm not going to fight too hard for this one if it steps on bigger and better plans of yours.  Your idea sounds more interesting anyway, so unless you want to use my idea in the interim I'm okay with closing this.  The patch here might at least serve as a useful reference.
Comment 11 Srinivasa Ragavan 2007-03-20 11:31:39 UTC
Matthew, I would like to do it in the way I proposed. I dont want to introduce stuff which we would anyway change. Also if we push this means that you gotto do some rework, bug fixes etc. Lets save your effort too :) for other things.