GNOME Bugzilla – Bug 395919
[Patch] Tangoified icon for Meld
Last modified: 2009-10-11 02:45:46 UTC
The current logo/icon does not fit well the currently "developed" default gnome-icon-theme. I created a new tangoified version of the current logo that can help to integrate Meld into the gnome menu as well as to the user's desktop. A package with the icon is attached to this bug report. Other information:
Created attachment 80142 [details] Tangoified icon for Meld Package includes all required sizes and also sources for them.
Created attachment 80197 [details] Tangoified icon for Meld Steven Garitty sugested to make the gloss a little bit transparent, so here is the updated version that replaces previous one. As in the previous case, all required sizes including "sources" are included in the package.
Thanks for the icons! Can you also make a patch to use and install the new icons?
Hi Stephen, I am afraid my artistic skills replace all my coding skills :/ All I know about the coding part of this is that icons should go to $prefix/share/icons/hicolor/<size>/apps/ and the code "how to get them" is probably the one mentioned at [1]. [1] - http://wayofthemonkey.com/?date=2006-11-15
What still needs to be done to get these icons in?
Ping, in case there's still time for this to get in to 2.24...
I have committed the icons to svn. (probably in the wrong place, but anyway...) The thing missing now is how to hook the icons up. 1) modify the install to put the icons in the right place 2) modify the source to find the new icons, both when installed and when run from an unpacked tarball.
Created attachment 129045 [details] [review] changed makefile to install new icon set I attached a patch to install the icon set (according to some other packages, they go to $(DESTDIR)$(sharedir)/icons/hicolor/{resolution}/apps/{appname.png}). I also did cp glade2/pixmaps/32x32/meld.png glade2/pixmaps/icon.png to replace the old one, so it also works when running from the tarball. I also had to add mkdir $(DESTDIR)$(sharedir_) in the makefile as otherwise I got the error "mkdir: could not create directory "/usr/share/meld": No such file or directory" but this probably does no harm.
Anything more than Stephan's patch to be done ? Can I commit this ?
Is there any way to include the SVG icon somewhere, to ensure that downstream packagers know about and use it? Also, has the patch been commited? I see the new icon in the application (GNOME 2.28 in Mandriva 2010.0 cooker), but not in the "hicolor" directory. So all the various sizes seem to have been left out. It seems a shame that such a nice range of optimized icons don't get used (e.g. gedit in gnome-do's docky shows up nice and smooth when the icon is magnified, but Meld is all blurry because the packagers use the smaller application icons).
I've just committed a modified version of Stefan's patch, so this bug should be fixed. As for the SVG icon, there was no actual scalable/ folder included, so I've just set the Makefile to install the SVG version from the 48x48/ folder. If that was the wrong thing to do, please let me know.