After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395908 - Support annotate option for viewcvs/viewvc/viewsvn/...
Support annotate option for viewcvs/viewvc/viewsvn/...
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: svn.gnome.org (obsolete)
current
Other All
: Normal normal
: ---
Assigned To: Bonsai Maintainers
Bonsai Maintainers
: 401326 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-12 20:10 UTC by Kristian Rietveld
Modified: 2007-02-18 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kristian Rietveld 2007-01-12 20:10:06 UTC
It would be great if viewsvn on the new subversion server would support annotating files in the repository.  For developers this is a very useful feature to, for example, chase back changed lines and patches.

Compare the old:
  http://cvs.gnome.org/viewcvs/gtk+/gtk/gtktreemodelsort.c

with:
  http://svn.gnome.org/viewcvs/gtk%2B/trunk/gtk/gtktreemodelsort.c

I also really like the format of the old repository log page -- IMHO it lists the changes in a very clear table.  I would be really happy if viewsvn on the new server would also look like this :)
Comment 1 Olav Vitters 2007-02-07 18:51:29 UTC
IIRC we do not use viewsvn, but viewcvs. To fix this (as answered on gnome-infrastructure) and because we admin svn.gnome.org, we not not develop viewcvs:

On Thu, Feb 01, 2007 at 11:26:30AM +0100, Murray Cumming wrote:
> On Tue, 2007-01-30 at 23:18 +0100, Josselin Mouette wrote:
> > I'd like to know if it would be possible to have a WebSVN interface on
> > svn.gnome.org, in addition to the good old viewcvs. I feel it is much
> > superior as it can list all files changed in a commit, and you don't
> > have to look for which files were modified in the same commit. (In fact,
> > any interface with that feature would be nice, it's just that I know
> > WebSVN.)
>
> Maintainership has much more difficult for me ever since we lost this
> feature when we lost the integrated bonsai/lxr system a couple of years
> ago. I'd really like this "list all files changed in a commit" feature.

I do not think it is a good idea to have multiple view* software things
installed (I'm not going to install another one and have twice the
maintenance load). We can however take the best one. I have no idea
which one that is. I'd guess 'viewvc' as it is more generic (we probably
have to have a view* on cvs.gnome.org for a while and using the same
software ensures it will be easier on us admins), but IIRC viewvc
doesn't have the annotate function either.

I do not have time to figure which one is the best. If someone could
shortly list the differences between all those view* I'd appreciate it.
I'm especially interested if the view*
 * is secure (track record and the way it is written/designed)
 * the software is actively maintained
 * what features we would not have anymore compared to the viewcvs on
   svn.gnome.org
 * if the URL structure is close enough so I can redirect /viewcvs/ to
   /viewwhatever/ and know it will usually do the right thing
 * easily able to switch (e.g. still uses same bonsai db structure)
 * if it had that annotate option
Comment 2 Kristian Rietveld 2007-02-07 18:57:19 UTC
(In reply to comment #1)
> IIRC we do not use viewsvn, but viewcvs. To fix this (as answered on
> gnome-infrastructure) and because we admin svn.gnome.org, we not not develop
> viewcvs:

I keep confusing viewcvs and viewsvn too, still wondering whether they are just the same.

So, if the current server is using viewcvs, and the old server is using viewcvs, is there any problem with getting annotation and the "old" revision log page to work?

(As a sidenote, I wonder why the mail you posted is asking for a listing of all changed files in a commit/revision -- this is something which is working fine with the current viewcvs on the subversion server).
Comment 3 John Stowers 2007-02-07 19:08:27 UTC
ViewCVS became ViewVC when they released 1.0 and made svn a first class supported citizen.

We seem to be running 1.0-dev and the latest ViewVC version is 1.0.3.

An example of what ViewVC can now do is http://viewvc.tigris.org/source/browse/viewvc/
Comment 4 Dan Nicholson 2007-02-07 20:22:24 UTC
The CHANGES file in viewvc seems to say there was a fix for SVN annotate in version 1.0.2.

http://viewvc.tigris.org/source/browse/viewvc/tags/1.0.3/CHANGES?rev=1447&view=markup
Comment 5 Dan Nicholson 2007-02-07 20:30:21 UTC
Also interesting is that the viewvc repo (which is in svn and presumably uses viewvc for the web interface) has annotate support.

http://viewvc.tigris.org/source/browse/viewvc/tags/1.0.3/CHANGES?annotate=1447

My viewvc is 1.0.0 and /etc/viewvc.conf has this option:

# allow annotation of files.
allow_annotate = 1

Although, I'm getting an exception right now, so I can't say it's working.
Comment 6 Kristian Rietveld 2007-02-07 20:34:48 UTC
The CHANGES file there already mentions annotate for much earlier versions.  The CHANGES file doesn't say much, and they don't have a proper ChangeLog file so I looked through the source code a bit.  It appears that annotate/blame support has been in there since revision 86 or 93, which were both committed in the year 2000.
Comment 7 Olav Vitters 2007-02-07 20:54:09 UTC
Just checked, and that config option is enabled. I guess we need to upgrade viewvc (and check what local changes we've made...).

In comment 1, I actually think they want a diff view for all changed files (meaning: show the diffs of multiple files).
Comment 8 Olav Vitters 2007-02-18 11:29:20 UTC
*** Bug 401326 has been marked as a duplicate of this bug. ***
Comment 9 Olav Vitters 2007-02-18 11:30:44 UTC
Fixed after the viewvc update.
Comment 10 Kristian Rietveld 2007-02-18 14:40:05 UTC
Awesome, thanks much!