After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395536 - [wavpackenc] Trivial cleanup
[wavpackenc] Trivial cleanup
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal trivial
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-11 19:40 UTC by Sebastian Dröge (slomo)
Modified: 2007-01-11 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wavpackenc-enum.diff (2.15 KB, patch)
2007-01-11 19:40 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2007-01-11 19:40:25 UTC
Hi,
the attached patch uses the C enums in the GEnums as in all other places to not hardcode the values.

Bye
Comment 1 Sebastian Dröge (slomo) 2007-01-11 19:40:43 UTC
Created attachment 80061 [details] [review]
wavpackenc-enum.diff
Comment 2 Tim-Philipp Müller 2007-01-11 19:51:38 UTC
Thanks, committed:

 2007-01-11  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge  <slomo@circular-chaos.org>

        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_mode_get_type),
        (gst_wavpack_enc_correction_mode_get_type),
        (gst_wavpack_enc_joint_stereo_mode_get_type):
          Minor clean-up: use enum values instead of hardcoded constants 
          (#395536).