GNOME Bugzilla – Bug 395433
Update / provide new multimedia key plugin which support the new GNOME 2.18 dbus interface
Last modified: 2007-04-18 21:15:53 UTC
Since control-center 2.17.5 there is a new dbus interface in GNOME for multimedia key support. It would be nice if banshee would use this interface if avaiable.
Created attachment 80660 [details] [review] A sample implementation as a patch against the multimedia kays plugin
If someone could be kind enough to commit this :) banshee in gnome 2.17/2.18 shows a regression without this patch. Thanks in advance to the kind soul who will commit this patch.
I can confirm this bug, tho I haven't tested the patch..
I can also confirm this bug, fixed via the patch.
*** Bug 414427 has been marked as a duplicate of this bug. ***
This patch has been applied to the Banshee package in Ubuntu to good effect. https://bugs.launchpad.net/bugs/87299
Perfect, marking for final review then. Which means it'll probably go in when we're merging trunk together. Thanks everybody, great work Jan!
This patch is quite hard to follow as you have replaced the spaces with tabs, so it's hard to tell what actually changed and what you reformatted. It would be very nice if you could turn the tabs back into 4 spaces and create a new patch.
While I like the concept of the settings daemon to handle MM Keys, this patch breaks legacy support completely by simply removing it.
Jan, I have taken your patch and turned it into a standalone component that is initialized at startup. That is, it is no longer a plugin. This new DBus method is too simple and really shouldn't be a plugin at all. If the component does not load (i.e. not using GNOME 2.18+), then the legacy X11 special keys plugin will load. The plugin is unmodified in my commit. If the component does load, then the legacy plugin will be disabled completely. The overhead of loading and instantiating the plugin assembly from disk is removed if running GNOME 2.18+. Here's my commit: http://svn.gnome.org/viewcvs/banshee?view=rev&revision=2225 The caveat: I am running GNOME 2.16, so while I have tested that the component/plugin loading logic is correct, I cannot test the actual DBus/UI support, though I did just copy/paste from Jan's patch. Anyone running GNOME 2.18+, please test my commit (rev. 2225). I'm going to mark the patch as committed, even though it was heavily re-worked to allow for backwards compatibility between GNOME versions. Still, it's all based on code in the patch. Thanks Jan!