After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395328 - Map kATSDeletedGlyphcode to PANGO_GLYPH_EMPTY
Map kATSDeletedGlyphcode to PANGO_GLYPH_EMPTY
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2007-01-11 09:28 UTC by Richard Hult
Modified: 2007-01-18 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle deleted atsui glyph code (944 bytes, patch)
2007-01-11 09:29 UTC, Richard Hult 		none Details | Review

Description Richard Hult 2007-01-11 09:28:14 UTC 
As discussed in https://bugs.freedesktop.org/show_bug.cgi?id=9530, we need to handle kATSDeletedGlyphcode. Will attach a patch that maps it to PANGO_GLYPH_EMPTY, which is already handled properly in pangocairo-atsui-font.c.

Btw, do we need to add a component for the atsui backend?
Comment 1 Richard Hult 2007-01-11 09:29:03 UTC 
Created attachment 80015 [details] [review]
Handle deleted atsui glyph code
Comment 2 Behdad Esfahbod 2007-01-11 22:47:04 UTC 
A simpler patch would be:

- glyphs->glyphs[i].glyph = glyph;
+ glyphs->glyphs[i].glyph = G_UNLIKELY (glyph == kATSDeletedGlyphcode) ? PANGO_GLYPH_EMPTY : glyph;

Is that ok?
Feel free to commit to trunk and pango-1-14 branch, but if you do, please keep my ChangeLog style by copying the bug description from the first line of this bugzilla page (including the em-dash!).

Thanks.
Comment 3 Behdad Esfahbod 2007-01-17 22:52:45 UTC 
2007-01-17  Behdad Esfahbod  <behdad@gnome.org>

        Bug 395328 – Map kATSDeletedGlyphcode to PANGO_GLYPH_EMPTY

        * modules/basic/basic-atsui.c (set_glyph): Handle
        kATSDeletedGlyphcode.
Comment 4 Richard Hult 2007-01-18 07:37:32 UTC 
Thanks for commtting, I have been a bit busy the last couple of days.