After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395124 - library monitoring adds hidden files to the library
library monitoring adds hidden files to the library
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.9.7
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-10 19:18 UTC by Brendan Martens
Modified: 2007-03-20 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.44 KB, patch)
2007-03-14 08:42 UTC, James "Doc" Livingston 		committed Details | Review

Description Brendan Martens 2007-01-10 19:18:24 UTC 
Please describe the problem:
I understand that the import function was fixed so that RB does not import hidden files, however, if you have library monitoring turned on

Steps to reproduce:
1. Turn on library monitoring.
2. Place at least one hidden file into the library ie: "/musicfolder/artist/album/.track"
3. Rhythmbox will automatically add that file when it scans the folder next.


Actual results:
That is what actually happens....

Expected results:
Rhythmbox should not add hidden files.

Does this happen every time?
Yes.

Other information:
This bug is related, it fixes this issue with importing new music. It simply needs to be extended to the Music Library monitoring function.

http://bugzilla.gnome.org/show_bug.cgi?id=346322
Comment 1 Ed Catmur 2007-01-12 18:21:25 UTC 
See patch at bug 395644 comment 3.
Comment 2 Brendan Martens 2007-03-13 14:38:34 UTC 
Just wanted to bump this bug... It's pretty frustrating, it's been a showstopper in Rhythmbox for me for a bit now. I've had to use Banshee. : ( Ick.
Comment 3 Brendan Martens 2007-03-13 14:40:03 UTC 
Sorry, just noticed that previous comment, but as far as I can tell this is not fixed. I'm using RB 0.9.8, and I still have the same problem. : (
Comment 4 James "Doc" Livingston 2007-03-14 08:42:50 UTC 
Created attachment 84561 [details] [review]
patch

We were only checking whether the path relative to the recursion root has a '.' prefix, rather than the path relative to it's parent. This meant that '.foo' would correctly be ignored, but not 'bar/.foo'. This patch fixes it and uses our async recursive function rather than re-implementing it with a thread pool.
Comment 5 Brendan Martens 2007-03-14 14:06:07 UTC 
Oh! That is very good news! Do you know when this will go in? 0.9.9? I presume? Thanks Doc.
Comment 6 James "Doc" Livingston 2007-03-20 12:24:20 UTC 
Committed to stable and trunk.