After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 394567 - Use correct FBTYPE values in GroupWise calendar backend
Use correct FBTYPE values in GroupWise calendar backend
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: libical
1.8.x (obsolete)
Other Linux
: High normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-01-09 10:34 UTC by Jari Urpalainen
Modified: 2009-11-27 11:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
line-endings patch and typos in fbtypes (2.21 KB, patch)
2007-01-09 10:36 UTC, Jari Urpalainen
needs-work Details | Review
revised line endings patch + fbtypes (5.17 KB, patch)
2008-09-04 07:47 UTC, Jari Urpalainen
committed Details | Review

Description Jari Urpalainen 2007-01-09 10:34:44 UTC
rfc 2445:
3.1.  Content Lines

   The iCalendar object is organized into individual lines of text,
   called content lines.  Content lines are delimited by a line break,
   which is a CRLF sequence (US-ASCII decimal 13, followed by US-ASCII
   decimal 10).

unfortunately there are some buggy/lousy ical parsers which doesn't support plain linefeed.

FBTYPES BUSY-TENTATIVE and BUSY-UNAVAILABLE are missing the hyphen "-" character
Comment 1 Jari Urpalainen 2007-01-09 10:36:48 UTC
Created attachment 79838 [details] [review]
line-endings patch and typos in fbtypes

patched against 1.8.2 but seems to apply also to svn trunk
Comment 2 Kjartan Maraas 2007-01-25 14:24:10 UTC
Please someone review this patch.
Comment 3 Matthew Barnes 2007-04-03 18:44:18 UTC
Patch looks okay, though it's hard to tell if it catches all the places where the iCalendar line break string needs to change.  Worth double-checking.

It would be better to define the line break sequence in one place:

   #define ICAL_NEWLINE "\r\n"

I'd prefer Chen have a look at this as well.  CC'ing him.
Comment 4 Chenthill P 2007-04-09 08:57:16 UTC
The patch looks good. Please incorporate the above mentioned changes.
Comment 5 Chenthill P 2007-04-10 10:39:13 UTC
You would also need to change FBTYPE strings used in e-cal-backend-groupwise-utils.c 
Comment 6 Jari Urpalainen 2008-09-04 07:47:56 UTC
Created attachment 117983 [details] [review]
revised line endings patch + fbtypes

made the requested changes (sorry for a long delay)
Comment 7 André Klapper 2008-11-13 19:24:30 UTC
Chen/Matthew, can this patch go in please?
Comment 8 Milan Crha 2009-11-27 11:33:32 UTC
Evolution is using upstream libical these days, and as I checked its sources all from the above is applied there, in some different form, except of the groupwise calendar change, which I'm just about to commit.
Comment 9 Milan Crha 2009-11-27 11:38:53 UTC
Created commit 39698b7 in eds master (2.29.3+)
Created commit 52881a7 in eds gnome-2-28 (2.28.2+)