GNOME Bugzilla – Bug 394567
Use correct FBTYPE values in GroupWise calendar backend
Last modified: 2009-11-27 11:39:03 UTC
rfc 2445: 3.1. Content Lines The iCalendar object is organized into individual lines of text, called content lines. Content lines are delimited by a line break, which is a CRLF sequence (US-ASCII decimal 13, followed by US-ASCII decimal 10). unfortunately there are some buggy/lousy ical parsers which doesn't support plain linefeed. FBTYPES BUSY-TENTATIVE and BUSY-UNAVAILABLE are missing the hyphen "-" character
Created attachment 79838 [details] [review] line-endings patch and typos in fbtypes patched against 1.8.2 but seems to apply also to svn trunk
Please someone review this patch.
Patch looks okay, though it's hard to tell if it catches all the places where the iCalendar line break string needs to change. Worth double-checking. It would be better to define the line break sequence in one place: #define ICAL_NEWLINE "\r\n" I'd prefer Chen have a look at this as well. CC'ing him.
The patch looks good. Please incorporate the above mentioned changes.
You would also need to change FBTYPE strings used in e-cal-backend-groupwise-utils.c
Created attachment 117983 [details] [review] revised line endings patch + fbtypes made the requested changes (sorry for a long delay)
Chen/Matthew, can this patch go in please?
Evolution is using upstream libical these days, and as I checked its sources all from the above is applied there, in some different form, except of the groupwise calendar change, which I'm just about to commit.
Created commit 39698b7 in eds master (2.29.3+) Created commit 52881a7 in eds gnome-2-28 (2.28.2+)