After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 394313 - Send playback key events if no player listening
Send playback key events if no player listening
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Keybinding
2.17.x
Other Linux
: Normal major
: ---
Assigned To: Jens Granseuer
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-08 17:34 UTC by Bastien Nocera
Modified: 2007-02-09 17:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
gsd-send-key-events-if-no-player.patch (1.67 KB, patch)
2007-01-08 19:11 UTC, Bastien Nocera 		needs-work Details | Review
eat media keys when someone's listening on the bus (3.07 KB, patch)
2007-02-06 22:31 UTC, Jens Granseuer 		committed Details | Review

Description Bastien Nocera 2007-01-08 17:34:48 UTC 
+++ This bug was initially created as a clone of Bug #133815 +++

acme_filter_events() should be eating the keyboard presses for the old XF86* keyboard shortcuts, if there are clients capturing the playback keys, so that the players don't get both the key press, and the dbus signal.
Comment 1 Bastien Nocera 2007-01-08 19:11:18 UTC 
I've retitled the patch properly, and attached the start of a patch.

I've also removed a few people in the CC:, please re-add yourself if it was in error.
Comment 2 Bastien Nocera 2007-01-08 19:11:48 UTC 
Created attachment 79777 [details] [review]
gsd-send-key-events-if-no-player.patch
Comment 3 Jens Granseuer 2007-02-05 21:45:27 UTC 
Bastien, is it sufficient to just check whether the gnome_settings_server->media_player != NULL to determine whether any apps are listening?
Comment 4 Bastien Nocera 2007-02-05 22:45:14 UTC 
(In reply to comment #3)
> Bastien, is it sufficient to just check whether the
> gnome_settings_server->media_player != NULL to determine whether any apps are
> listening?

Yeah, should be.
Comment 5 Jens Granseuer 2007-02-05 22:53:26 UTC 
Ok, um, then your patch is missing, like, 3 lines or so?

I'm taking this, but I smell a trap...
Comment 6 Bastien Nocera 2007-02-05 22:57:25 UTC 
Not sure why I didn't finish this patch :)
Comment 7 Jens Granseuer 2007-02-06 22:31:05 UTC 
Created attachment 82048 [details] [review]
eat media keys when someone's listening on the bus

So, this should be the full thing, then?
Comment 8 Jens Granseuer 2007-02-07 07:48:46 UTC 
.. except that the return value of gnome_settings_server_media_player_key_pressed needs to be inverted, of course.

Still not short enough to not squeeze a bug in. Doh!
Comment 9 Bastien Nocera 2007-02-09 00:39:53 UTC 
Looks good.
Comment 10 Jens Granseuer 2007-02-09 17:02:48 UTC 
Ok, committed with the fix.