After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 394003 - Polypaudio is renamed to PulseAudio
Polypaudio is renamed to PulseAudio
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
git master
Other All
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 397403 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-07 19:47 UTC by Gabor Kelemen
Modified: 2007-02-02 16:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Trivial fix (975 bytes, patch)
2007-01-07 23:35 UTC, Gabor Kelemen 		none Details | Review
Updated patch (959 bytes, patch)
2007-02-01 11:01 UTC, Gabor Kelemen 		committed Details | Review

Description Gabor Kelemen 2007-01-07 19:47:29 UTC 
+++ This bug was initially created as a clone of Bug #349305 +++

Please describe the problem:
GStreamer-Properties is probing for "polypsink/polypsrc" elements. These are no longer available. "pulsesink" and "pulsesrc" are the new names of these elements. 


capplets/sound/sound-properties-capplet.c uses these as well.
Comment 1 Gabor Kelemen 2007-01-07 23:35:15 UTC 
Created attachment 79693 [details] [review]
Trivial fix
Comment 2 Jens Granseuer 2007-01-29 14:20:33 UTC 
*** Bug 397403 has been marked as a duplicate of this bug. ***
Comment 3 Bob Mauchin 2007-01-29 15:02:50 UTC 
From bug 397403 :
During tranlation, I've notice that this is already done in
Gstreamer-properties, but in this way : "Pulse - PulseAudio Sound Server"

Would you mind changing your patch to this translation in order to have a consistant UI ?

Thanks.
Comment 4 Gabor Kelemen 2007-01-29 16:25:17 UTC 
(In reply to comment #3)
> From bug 397403 :
> During tranlation, I've notice that this is already done in
> Gstreamer-properties, but in this way : "Pulse - PulseAudio Sound Server"
> 
> Would you mind changing your patch to this translation in order to have a
> consistant UI ?
> 
> Thanks.
> 

I don't think my patch should be changed. 
You propose in http://bugzilla.gnome.org/show_bug.cgi?id=397403#c2
the following: 

+	add_device (AUDIO_PLAYBACK, "polypsink", _("Pulse - PulseAudio Sound Server"), NULL);
+	add_device (AUDIO_CAPTURE, "polypsrc", _("Pulse - PulseAudio Sound Server"), NULL);

However, my patch changes it to: 

+	add_device (AUDIO_PLAYBACK, "pulsesink", _("Pulse - PulseAudio Sound Server"), NULL);
+	add_device (AUDIO_CAPTURE, "pulsesrc", _("Pulse - PulseAudio Sound Server"), NULL); 

According to bug #349345, the audio elements were renamed to pulsesink/pulsesrc, so i think it's correct to rename them here too. The user-visible description is consistent, I stole it from the cloned gnome-media bug :).
Comment 5 Bob Mauchin 2007-01-29 17:27:32 UTC 
Oops sorry I did not read carefully your patch, and you're right.
Apologizes :|

Thanks.
Comment 6 Jens Granseuer 2007-01-30 21:19:42 UTC 
I'd actually prefer dropping the somewhat unnecessary "Pulse -" from the sound source/sink description. Even if that means changing it in gnome-media, too...
Comment 7 Gabor Kelemen 2007-02-01 10:59:18 UTC 
(In reply to comment #6)
> I'd actually prefer dropping the somewhat unnecessary "Pulse -" from the sound
> source/sink description. Even if that means changing it in gnome-media, too...
> 

Agree, Pulse - is unnecessary at the beginning of the description. I will attach a new patch, please open a bug for this against gnome-media.
Comment 8 Gabor Kelemen 2007-02-01 11:01:09 UTC 
Created attachment 81648 [details] [review]
Updated patch
Comment 9 Jens Granseuer 2007-02-01 23:05:09 UTC 
I just reopened bug 349305 against gnome-media
Comment 10 Jens Granseuer 2007-02-02 16:38:14 UTC 
Patch committed, string change announcement sent.