After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393218 - Use default invisible_char instead of hardcoding it
Use default invisible_char instead of hardcoding it
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
0.9.x
Other All
: Normal minor
: 1.0.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2007-01-05 17:36 UTC by Vitaliy Ischenko
Modified: 2007-01-26 01:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (honestly i don't think it is good) (1.03 KB, patch)
2007-01-05 17:43 UTC, Vitaliy Ischenko 		none Details | Review
Also patch glade files to have default invisible_char (11.11 KB, patch)
2007-01-07 13:37 UTC, Vitaliy Ischenko 		none Details | Review

Description Vitaliy Ischenko 2007-01-05 17:36:11 UTC 
Some linux distros patch gtk to use something instead of '*' as invisible char, but it seems, that some use 0x2022 and others 0x25cf.
So it would be better to use hardcoded value if, and only if default is '*' atherwise -- use gtk default

Other information:
Comment 1 Vitaliy Ischenko 2007-01-05 17:43:30 UTC 
Created attachment 79468 [details] [review]
Patch (honestly i don't think it is good)

The code is self-explanatory
Please, also look at bug 307304
I think that after closing bug 307304 this patch will be obsolete
Comment 2 Vitaliy Ischenko 2007-01-07 13:37:21 UTC 
Created attachment 79626 [details] [review]
Also patch glade files to have default invisible_char
Comment 3 Stef Walter 2007-01-26 01:04:45 UTC 
Thanks. Committed your patches with a few modifications:

2007-01-25  Nate Nielsen  <nielsen@memberwebs.com>

	* libseahorse/seahorse-add-keyserver.glade:
	* libseahorse/seahorse-secure-entry.c:
	* src/seahorse-add-uid.glade:
	* src/seahorse-change-passphrase.glade:
	* src/seahorse-gkeyring-item-properties.glade:
	* src/seahorse-key-manager.glade:
	* src/seahorse-keyserver-search.glade:
	* src/seahorse-multi-encrypt.glade:
	* src/seahorse-pgp-generate.glade:
	* src/seahorse-revoke.glade:
	* src/seahorse-ssh-generate.glade:
	* src/seahorse-ssh-key-properties.glade:
	* src/seahorse-ssh-upload.glade: Get invisible character from 
	GtkEntry, remove hard coded invisible char in glade. 
	Patch by Vitaliy Ischenko. Fixes bug #393218