After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 392638 - [directsoundsink] dist and add to gst-plugins-bad
[directsoundsink] dist and add to gst-plugins-bad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.5
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-04 07:21 UTC by Vincent Torri
Modified: 2007-01-04 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch that adds the compilation of directsoundsink (3.62 KB, patch)
2007-01-04 07:22 UTC, Vincent Torri 		committed Details | Review
Makefile.am for the compilation of directsoundsink plugin (457 bytes, text/plain)
2007-01-04 07:23 UTC, Vincent Torri 		  Details

Description Vincent Torri 2007-01-04 07:21:43 UTC 
I've added the compilation of directsoundsink in gst-plugins-bad.
there are below the patch that:
* adds a check in configure.ac for some win32 header files and libs, and remove the useless check of header files of directdraw
* adds the compilation in sys/Makefile.am
* fixes a warning in gstdirectsoundsink.c

Also, I've added the needed Makefile.am below
Comment 1 Vincent Torri 2007-01-04 07:22:29 UTC 
Created attachment 79364 [details] [review]
patch that adds the compilation of directsoundsink
Comment 2 Vincent Torri 2007-01-04 07:23:25 UTC 
Created attachment 79365 [details]
Makefile.am for the compilation of directsoundsink plugin
Comment 3 Tim-Philipp Müller 2007-01-04 09:47:35 UTC 
Thanks, committed:

 2007-01-04  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Vincent Torri  <vtorri at univ-evry fr>

        * configure.ac:
        * sys/Makefile.am:
        * sys/directsound/Makefile.am:
        * sys/directsound/gstdirectsoundsink.c:
        (gst_directsoundsink_reset):
          Add directsoundsink to build and dist it, so it gets built when
          compiling with MingW on win32 and the required headers and libraries
          are available (fixes: #392638). Also simplify DirectDraw check a bit.

        * tests/check/elements/.cvsignore:
          Fix CVS ignore for neonhttpsrc test binary.

(I moved the -lgstaudio-0.10 bit in sys/directsound/Makefile.am behind the GST_PLUGINS_BASE_CFLAGS though, since it's a -base lib; same for yesterday's directdraw patch)