Bug 392632 – crash in gThumb Image Viewer: repeatedly pressing Ctrl...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 392632 - crash in gThumb Image Viewer: repeatedly pressing Ctrl...


Summary:	crash in gThumb Image Viewer: repeatedly pressing Ctrl...


Status:	RESOLVED FIXED

Product:	gthumb
Classification:	Other
Component:	general
Version:	2.9.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	Paolo Bacchilega
QA Contact:	Paolo Bacchilega

URL:
Whiteboard:

Duplicates:	392721 (view as bug list)
Depends on:
Blocks:

Reported:	2007-01-04 06:52 UTC by chardamon
Modified:	2007-02-07 19:07 UTC

See Also:
GNOME target:	---
GNOME version:	2.15/2.16

Attachments
ignore a new gth_pixbuf_op when there already one running (848 bytes, patch) 2007-02-07 18:55 UTC, manuel braga	accepted-commit_now	Details \| Review

Description chardamon 2007-01-04 06:52:54 UTC

What were you doing when the application crashed?
repeatedly pressing Ctrl-Shift-E


Distribution: Fedora Core release 6 (Zod)
Gnome Release: 2.16.0 2006-09-04 (Red Hat, Inc)
BugBuddy Version: 2.16.0

System: Linux 2.6.18-1.2849.fc6 #1 SMP Fri Nov 10 12:45:28 EST 2006 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70101000
Selinux: Enforcing
Accessibility: Disabled
----------- .xsession-errors ---------------------
VM file ui compiled to 786313 bytes of code
ui loaded in 4596672 bytes on the hunk
UI menu load time = 479 milli seconds
UI menu load time = 53 milli seconds
UI menu load time = 51 milli seconds
]\quit 
----- CL_Shutdown -----
Closing SDL audio device...
SDL audio device shut down.
RE_Shutdown( 1 )
-----------------------
----- CL_Shutdown -----
-----------------------
** (bug-buddy:3974): WARNING **: Couldn't load icon for Open Folder
--------------------------------------------------

Memory status: size: 252551168 vsize: 0 resident: 252551168 share: 0 rss: 20262912 rss_rlim: 0
CPU usage: start_time: 1167893470 rtime: 0 utime: 331 stime: 0 cutime:304 cstime: 0 timeout: 27 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/gthumb'

(no debugging symbols found)
Using host libthread_db library "/lib/libthread_db.so.1".
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1208568112 (LWP 3951)]
[New Thread -1439241328 (LWP 3963)]
[New Thread -1428751472 (LWP 3962)]
[New Thread -1418261616 (LWP 3961)]
[New Thread -1407771760 (LWP 3960)]
[New Thread -1344832624 (LWP 3954)]
[New Thread -1251714160 (LWP 3953)]
(no debugging symbols found)
0x00b9d402 in __kernel_vsyscall ()

+ Trace 99236

Thread 1 (Thread -1208568112 (LWP 3951))

#0 __kernel_vsyscall
#1 waitpid
from /lib/libpthread.so.0
#2 gnome_gtk_module_info_get
from /usr/lib/libgnomeui-2.so.0
#3 <signal handler called>
#4 gth_browser_get_sidebar_content
#5 g_cclosure_marshal_VOID__BOOLEAN
from /lib/libgobject-2.0.so.0
#6 g_closure_invoke
from /lib/libgobject-2.0.so.0
#7 g_signal_override_class_closure
from /lib/libgobject-2.0.so.0
#8 g_signal_emit_valist
from /lib/libgobject-2.0.so.0
#9 g_signal_emit
from /lib/libgobject-2.0.so.0
#10 gth_pixbuf_op_set_single_step
from /usr/lib/gthumb/libgthumb.so
#11 g_source_is_destroyed
from /lib/libglib-2.0.so.0
#12 g_main_context_dispatch
from /lib/libglib-2.0.so.0
#13 g_main_context_check
from /lib/libglib-2.0.so.0
#14 g_main_loop_run
from /lib/libglib-2.0.so.0
#15 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#16 main
#0 __kernel_vsyscall

Comment 1 Michael Chudobiak 2007-01-04 12:56:02 UTC

*** Bug 392721 has been marked as a duplicate of this bug. ***

Comment 2 Michael Chudobiak 2007-01-04 12:57:18 UTC

Better stacktrace in bug 392721.

Comment 3 manuel braga 2007-02-07 18:51:28 UTC

Each time when the Ctrl-Shift-E is pressed, in the function gth_window_activate_action_alter_image_adjust_levels, a new gth_pixbuf_op object is created, but the gth-browser/gth-viewer can only hold one gth_pixbuf_op object, the old is lost but it has a live timeout (the step function).

The multiple pressing, causes multiples gth_pixbuf_op operations, when the first ends it set priv->pixop to NULL, then when the nexts ends segfault.

Maybe the best solution is to disable the gtk_action when a gth_pixbuf_op operation starts, and reenable when finish.
What you think?

Comment 4 manuel braga 2007-02-07 18:55:23 UTC

Created attachment 82096 [details] [review]
ignore a new gth_pixbuf_op when there already one running

A quick fix, to avoid the segfault.

Comment 5 Paolo Bacchilega 2007-02-07 19:07:27 UTC

patch committed to svn trunk, thanks.