After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 392432 - Eject action not greyed out
Eject action not greyed out
Status: RESOLVED FIXED
Product: hipo
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Hipo Maintainer(s)
Hipo Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-01-03 19:14 UTC by Pedro Villavicencio
Modified: 2007-01-08 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
All actions should be "greyed". Fixed (928 bytes, patch)
2007-01-07 09:46 UTC, Gabriel Felipe Cornejo 		needs-work Details | Review
I believe that the bug is already repaired (847 bytes, patch)
2007-01-08 00:33 UTC, Gabriel Felipe Cornejo 		none Details | Review
I believe that the bug is already repaired. :-) (723 bytes, patch)
2007-01-08 08:42 UTC, Gabriel Felipe Cornejo 		committed Details | Review

Description Pedro Villavicencio 2007-01-03 19:14:51 UTC 
The Eject option in the menu is not greyed out when there is no ipod connected and when it is clicked it shows an error.
Comment 1 Felipe Barros S. 2007-01-03 23:01:42 UTC 
(In reply to comment #0)
> The Eject option in the menu is not greyed out when there is no ipod connected
> and when it is clicked it shows an error.
> 

this bug is a real candidate for gnome-love tag
Comment 2 Pedro Villavicencio 2007-01-03 23:54:19 UTC 
sure, no problem, the other actions should be greyed out too.

marked as gnome-love.
Comment 3 Gabriel Felipe Cornejo 2007-01-07 09:46:28 UTC 
Created attachment 79611 [details] [review]
All actions should be "greyed". Fixed
Comment 4 Pedro Villavicencio 2007-01-07 15:51:56 UTC 
(In reply to comment #3)
> Created an attachment (id=79611) [edit]
> All actions should be "greyed". Fixed
> 

Hello,

Gabriel, just a little issue that you maybe forgot, if you connect the ipod again the objects remains greyed out, so is a better idea use the greyed variable like this:


group["AddFile"].Sensitive = greyed;

It looks good ah other thing please use the hipo version from the GNOME SVN the one from GNOME CVS is out of date, you can download it with:

svn checkout http://svn.gnome.org/svn/hipo/trunk hipo 

and generate your patch with: svn diff > greyed.diff

Thanks a lot for your help ;-)
Comment 5 Gabriel Felipe Cornejo 2007-01-08 00:33:41 UTC 
Created attachment 79698 [details] [review]
I believe that the bug is already repaired
Comment 6 Gabriel Felipe Cornejo 2007-01-08 08:42:36 UTC 
Created attachment 79723 [details] [review]
I believe that the bug is already repaired.  :-)
Comment 7 Pedro Villavicencio 2007-01-08 12:11:46 UTC 
Hello,

Gabriel, yes it does!, I'm going to commit it to HEAD right now, thanks a lot for fix our first gnome-love bug ;-)