After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 392112 - [rfbsrc] doesn't build with MinGW
[rfbsrc] doesn't build with MinGW
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-02 23:34 UTC by Vincent Torri
Modified: 2007-01-05 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for the compilation of rfbdecoder.c with MinGW (1.18 KB, patch)
2007-01-02 23:36 UTC, Vincent Torri 		needs-work Details | Review

Description Vincent Torri 2007-01-02 23:34:29 UTC 
See below for a patch that make rfbdecoder.c compile with MinGW

For the link, -lwsock32 -lws2_32 are needed. I don't really know what is the best way to to that in configure.ac
Comment 1 Vincent Torri 2007-01-02 23:36:14 UTC 
Created attachment 79234 [details] [review]
patch for the compilation of rfbdecoder.c with MinGW
Comment 2 Vincent Torri 2007-01-03 06:53:44 UTC 
in fact, only -lws2_32 is needed. If AC_CHECK_LIB is used, then the function to check is WSAStringToAddressA (for example)
Comment 3 Tim-Philipp Müller 2007-01-05 14:06:05 UTC 
> See below for a patch that make rfbdecoder.c compile with MinGW

It's good that it compiles, but have you actually tested whether it works? :)

For one, there seems to be WSAStartup() missing - is that not required for WSAStringToAddress() and connect() etc.?



> For the link, -lwsock32 -lws2_32 are needed. I don't really know what is the
> best way to to that in configure.ac

The configure.ac in gst-plugins-good does this for example.


For now I've only disabled compilation of rfbsrc if it can't find sys/socket.h. Hope that unbreaks compilation of gst-plugins-bad on MingW:


 2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

       * configure.ac:
         Don't compile rfbsource if we don't have sys/socket.h.
         Should fix compilation on MingW.



If you have a patch to port rfbdecoder.c to winsock2 that you've tested and that works, please open a new bug report for that (or re-open this one).