After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 391971 - Fix build with gcc-2.x
Fix build with gcc-2.x
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.4
Other All
: Normal normal
: 0.10.5
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
: 405005 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-02 17:39 UTC by Jens Granseuer
Modified: 2007-02-06 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
C89 fixes (4.54 KB, patch)
2007-01-02 17:40 UTC, Jens Granseuer 		committed Details | Review
fix casting issue (438 bytes, patch)
2007-01-02 17:41 UTC, Jens Granseuer 		committed Details | Review

Description Jens Granseuer 2007-01-02 17:39:28 UTC 
The following patches make -bad build with gcc 2 again.
Comment 1 Jens Granseuer 2007-01-02 17:40:02 UTC 
Created attachment 79199 [details] [review]
C89 fixes
Comment 2 Jens Granseuer 2007-01-02 17:41:15 UTC 
Created attachment 79201 [details] [review]
fix casting issue

Without this patch, the compiler fails with
gstmodplug.cc: In function `void gst_modplug_class_init(GstModPlugClass *)':
gstmodplug.cc:220: assignment to `GstStateChangeReturn (*)(GstElement *, GstStateChange)' from `GstStateChangeReturn ()(GstElement *, GstStateChange)'
make[4]: *** [libgstmodplug_la-gstmodplug.lo] Error 1
Comment 3 Tim-Philipp Müller 2007-01-03 16:41:22 UTC 
Thanks, committed:

  2007-01-03  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Jens Granseuer  <jensgr at gmx net>

        * ext/xvid/gstxvidenc.c: (gst_xvidenc_encode),
        (gst_xvidenc_get_property):
        * gst/filter/gstbpwsinc.c: (bpwsinc_transform_ip):
        * gst/filter/gstfilter.c: (plugin_init):
        * gst/filter/gstiir.c: (iir_transform_ip):
        * gst/filter/gstlpwsinc.c: (lpwsinc_transform_ip):
        * gst/modplug/gstmodplug.cc:
        * gst/nuvdemux/gstnuvdemux.c: (gst_nuv_demux_header_load),
        (gst_nuv_demux_stream_extend_header):
          Fix build with gcc-2.x (declare variables at the beginning of a
          block etc.). Fixes #391971.
Comment 4 Tim-Philipp Müller 2007-02-06 15:15:06 UTC 
*** Bug 405005 has been marked as a duplicate of this bug. ***