After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 391909 - Fix compilation with MinGW
Fix compilation with MinGW
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal major
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 392473 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-02 15:02 UTC by Vincent Torri
Modified: 2007-01-05 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for compilation with mingw (2.00 KB, patch)
2007-01-02 15:02 UTC, Vincent Torri 		committed Details | Review

Description Vincent Torri 2007-01-02 15:02:06 UTC 
gstinfo.h, gstconfig.h and gst_private.h use WIN32 variable to set which symbols must be exported on Windows platform (using __declspec, with a Microsoft compiler). MinGW also sets this variable, but must not use __declspec

The attached patch fix that problem by using the variable _MSC_VER instead of WIN32.
Comment 1 Vincent Torri 2007-01-02 15:02:54 UTC 
Created attachment 79184 [details] [review]
fix for compilation with mingw
Comment 2 Alberto Botti 2007-01-03 21:04:51 UTC 
*** Bug 392473 has been marked as a duplicate of this bug. ***
Comment 3 Samuel Cormier-Iijima 2007-01-04 06:13:00 UTC 
This fixes it for me as well, using MinGW
Comment 4 mammique 2007-01-04 22:09:04 UTC 
Fixed cross-compilation (linux->win32, using mingw32msvc) for me too.
Comment 5 Tim-Philipp Müller 2007-01-05 13:41:55 UTC 
Thanks! Hope this keeps things working with MSVC ...

 2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Vincent Torri  <vtorri at univ-evry dot fr>

        * gst/gst_private.h:
        * gst/gstconfig.h.in:
        * gst/gstinfo.h:
          On win32, all the __declspec stuff for symbol exporting is
          apparently only needed with MSVC, but doesn't work with MingW.
          Fixes compilation with MingW and #391909.