Created attachment 79143 [details] [review]
Proposed patch enabling bitrate on src caps

I think this is a nice feature to have. Let me know if there's a corner case i should know about.

I don't think anything ever sets mp3 bitrates in caps. I don't think it's a particularly sensible thing to add here.

The patch as-is is presumably wrong for VBR? If we wanted this, we'd have to detect VBR somehow, then suppress bitrate-in-caps.

I think we mostly use tag messages for this sort of thing; I'd prefer that unless there's a compelling reason to do otherwise.

well there are some plugins (demuxers, encoders) that are setting the bitrate in the caps.

This is pretty useful and sometimes even required for some decoders or muxers.

The bitrate can be a mandatory parameter for codec configuration and getting it through a tag seems wrong to me.

Now that mp3parse supports seeking, querying etc, is there any reason to have this patch?

In general, while the bitrate, could go in the caps, for VBR streams it _will_ change on every packet, causing a lot of unnecessary caps changes. Other mp3 parameters such as samplerate and channel count are free to change on every packet too, but they don't tend to whereas bitrate does.

mp3 isn't a format where it's necessary to put the bitrate in the caps.  I don't actually know of a format where it is *necessary*.  The appropriate place for it is in a tag.

Closing.