After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 391333 - Icon theme causing memory corruption in gtk+ 2.10.x
Icon theme causing memory corruption in gtk+ 2.10.x
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.10.x
Other All
: Normal critical
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-12-31 15:52 UTC by Olivier Fourdan
Modified: 2007-01-01 05:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PAtch that removes the freed theme from the internal theme list in gtkicontheme (416 bytes, patch)
2006-12-31 15:54 UTC, Olivier Fourdan 		none Details | Review

Description Olivier Fourdan 2006-12-31 15:52:48 UTC 
Steps to reproduce:
1. Get http://gnome-look.org/content/show.php?content=14484
2. Install this icon theme
3. Select Grounation as icon theme

=> All running gtk+ apps dies at once.

Stack trace:
The Grounation icon theme doesn't specify icon dirs. gtk correctly detect that and display a warning: 

Gtk-WARNING **: Theme file for Grounation has no directories

The theme is freed from memory (in gtk/gtkicontheme.c, insert_theme () line #955) but _not_ removed from the theme list, so the theme list reference freed memory that kills the app:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 98298

Thread 47790949198208 (LWP 17347)

  • #0 strcmp
    from /lib/libc.so.6
  • #1 gtk_icon_size_lookup
    from /usr/lib/libgtk-x11-2.0.so
  • #2 gtk_icon_theme_rescan_if_needed
    from /usr/lib/libgtk-x11-2.0.so
  • #3 gtk_icon_theme_lookup_icon
    from /usr/lib/libgtk-x11-2.0.so
  • #4 gtk_icon_theme_load_icon
    from /usr/lib/libgtk-x11-2.0.so
  • #5 gtk_icon_set_render_icon
    from /usr/lib/libgtk-x11-2.0.so
  • #6 gtk_widget_render_icon
    from /usr/lib/libgtk-x11-2.0.so
  • #7 gtk_image_new_from_pixmap
    from /usr/lib/libgtk-x11-2.0.so
  • #8 gtk_image_new_from_pixmap
    from /usr/lib/libgtk-x11-2.0.so 


Other information:
I think this is a serious problem. Patch against 2.10.6 follows.
Comment 1 Olivier Fourdan 2006-12-31 15:54:25 UTC 
Created attachment 79106 [details] [review]
PAtch that removes the freed theme from the internal theme list in gtkicontheme
Comment 2 Matthias Clasen 2007-01-01 05:28:04 UTC 
This is already fixed in both branches in svn. Thanks though.