GNOME Bugzilla – Bug 390518
authentication string bogus for local objects
Last modified: 2011-08-17 13:55:13 UTC
The attached patch fixes the authentication string construction for local objects.
Created attachment 79016 [details] [review] Proposed patch The attached patch ensures that we don't prepend a '/' character to local objects.
A similar patch has been committed to gnome-vfs.
So this will construct a string like "You must log in to access USER@SERVER/PATH domain DOMAIN" Shouldn't we make this a bit better by not constructing the string by parts but using different strings for each of these, i.e.: You must log in to access SERVER You must log in to access SERVER as user USER You must log in to access PATH at SERVER in domain DOMAIN [as user USER] ?
Good point. CCing usability team for feedback/further ideas.
Usability crew? Ping?
Different strings for cases with and without domains would be useful, at least (e.g. "You need to log in to access area DOMAIN on SERVER"). In cases where USER is unchangable, that seems like it would be better handled by a "Name:" field that was pre-filled and disabled, rather than by two times as many strings.
Christian, did you look at this again later?
Which component is this nowadays with having libgnomeui nearly killed?
I guess glib/gio/gvfs. Closing on this side.