After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 390268 - EOG crash when uncheck "open_new_window" in gconf
EOG crash when uncheck "open_new_window" in gconf
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.17.x
Other All
: Normal critical
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-28 08:10 UTC by vicky.sun
Modified: 2006-12-28 13:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18



Description vicky.sun 2006-12-28 08:10:06 UTC
Steps to reproduce:
1. Open gconf-editor in terminal.
2. Go to apps->eog->windwo, uncheck "open_new_windwo".
3. Open one image in EOG, the open another image 


Stack trace:
EOG crash and type information below in terminal:
GLib-GObject-CRITICAL **: file gsignal.c: line 1730: assertion `handler_id > 0' failed
aborting...


Other information:
Comment 1 vicky.sun 2006-12-28 08:13:30 UTC
The version shall be : Eye of GNOME 2.17.2
Comment 2 Felix Riemann 2006-12-28 12:10:34 UTC
Confirming.
We are apparently trying to disconnect a signal handler which has never been connected before.
Comment 3 Felix Riemann 2006-12-28 13:20:45 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.


I just committed a fix for it to HEAD and gnome-2-16 branches. eog-ng appears unaffected.

2006-12-28  Felix Riemann  <>

	* libeog/eog-image-list.c: (eog_image_list_class_init):
	* libeog/eog-image-list.h: Remove list-prepared signal as it is
	neither	emitted nor used anymore. 
	* libeog/eog-wrap-list.c: Remove some leftover handler_id variables.
	* shell/eog-window.c: (eog_window_init), (eog_window_open): We don't
	connect to EogImageList::list-prepared anymore, so there's no need to
	disconnect from it. This avoids some possibly fatal warnings when EOG
	is set to reuse its window. Fixes bug #390268.

The problem was that we were trying to disconnect a handler from EogImageList::list-prepared, but we don't connect to that signal anymore. Since the signals is unused and not even emitted anymore I completely removed it in HEAD.

For gnome-2-16 branch I used a safer approach.