GNOME Bugzilla – Bug 389668
Memos records in Evolution can't be synchronized to Palm
Last modified: 2018-07-02 10:33:44 UTC
Please describe the problem: Memos items in Evolution can't be synchronized to Palm. Steps to reproduce: 1.Creat a new record in Evolution->Memos. 2.Enable "Sync" option for Memos. 3.Press "Sync" button on Palm to start sync action. Actual results: New created record in Evolution can't be synchronized to Palm. Expected results: New created record in Evolution is synchronized to Palm. Does this happen every time? yes Other information:
Created attachment 78896 [details] [review] patch for this bug
Can you explain the problem in more detail? I've never had a sync problem, so if you can explain what text causes the sync to fail that'd be helpful. Based on what I see in your patch, you added a line to the Summary, but not the Description, and then it didn't sync. In reality, the Summary field shouldn't even be there. When Groupwise support was implemented last summer, the Summary and Start Date fields were added. They never should have been. A Memo/Note should have no Start Date. The Description would be where you put any text for the Memo, and then upon saving, the Memo copies up to 50 characters to the Summary field in the ECal object - this makes it easy to display a piece of the Memo in the Evolution Memos Table View. I had a detailed code-review of the patch, but once I realized what was probably the problem (let me know if I'm wrong) I realized the patch should just be removed - it doesn't really solve the problem. If the patch is ever used, it really needs to be looked at - I found a few things that I didn't like in it. PROPOSAL: What I propose instead is that a patch be written that removes the two fields I mentioned above, and then fills in the summary field automatically based on the Description. This is how the Memos component originally was designed, and there was a reason for it. I don't know much about Gw, but I believe the core code should not support the Date and Summary fields as they are currently supported. If this breaks Gw interaction, then maybe the Gw support should be re-looked at. If Gw is trying to use a Journal, then we need a Journal component. Memos was meant to be like the Memos component on the PalmOS PDA as well as the Notes component on Outlook. It was created to be compatible with these two, which is now broken. I believe the user pchen should be added to the CC list of this bug (don't know his e-mail) since pchen originally created the Gw support. Input from him would be greatly appreciated.
I think when you create a new record whose Summary field is only filled in Evolution Memos, the bug will be reproduced. Memos on PalmOS PDA only have Descritpion field, while Memos on Evolution have Summary and Description fields. When converting a ECalComponent object to a EMemoLocalRecord, the summary is got by e_cal_component_get_summary and the description is got by e_cal_component_get_description_list, then they are concatenated and assigned to memo->text. When converting to a ECalComponent object, the first '\n' in memo.text will be checked. If it's true, the text before the first '\n' will be converted to ECalComponent Summary and the left will be ECalComponent description. If it's not true, all of text will be Summary. I don't think 50 make sense because perhaps the first sentence in PalmOS PDA Memos will have more than 50 characters and Summary field in evolution Memos also can contain more than 50. Totally agree with you Memos shouldn't have Summary and Start Date fields.
Created attachment 82205 [details] [review] a new patch Change the value of text.value from NULL to a null string to avoid critical warning
I thought we decided we didn't want to use the summary field at all. A fix for this bug would be to get rid of the summary field and start date fields. The summary field would be used only for displaying a limited piece of the description in the table display of all Memos - it would be updated on-the-fly (as it was in the original Memos component before the Groupwise changes).
Marking the patch as needs-work as per comment#5.
Bumping version to a stable release.
Palm synchronization isn't our problem anymore. Reassigning.
gnome-pilot is not under active development anymore and has not seen code changes for seven years. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-pilot/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.