After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 389280 - Use EphySpinner instead of GossipThrobber
Use EphySpinner instead of GossipThrobber
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-24 20:01 UTC by Christian Persch
Modified: 2007-01-01 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (47.77 KB, patch)
2006-12-24 20:01 UTC, Christian Persch
committed Details | Review

Description Christian Persch 2006-12-24 20:01:08 UTC
GossipThrobber is an old version of NautilusThrobber; already many apps use the updated EphySpinner class (see http://live.gnome.org/Epiphany/EphySpinner : epiphany, nemiver, gedit, baobab and even nautilus itself).
Comment 1 Christian Persch 2006-12-24 20:01:30 UTC
Created attachment 78863 [details] [review]
patch
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2006-12-25 08:48:06 UTC
Works perfect for me.
go go EphySpinner!
Comment 3 Martyn Russell 2006-12-25 12:15:13 UTC
Committed, just out of interest, what are the highlights (i.e. what is better?)
Comment 4 Christian Persch 2006-12-27 14:46:34 UTC
Apart from code re-use, it fixes several problems with the new icon theme (blank image as first in animation, preferring process-working icon over the legacy gnome-spinner one), and it loads the animation from the themed icon of the right size instead of always scaling down.