After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 388717 - Improve connection error messages
Improve connection error messages
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
unspecified
Other All
: Normal minor
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-12-22 19:24 UTC by Guilhèm Bonnefille
Modified: 2007-01-08 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improve the g_message calls while socket creation errors (927 bytes, patch)
2006-12-22 19:28 UTC, Guilhèm Bonnefille
none Details | Review
Improve the message that occurs when the connection failed (1005 bytes, patch)
2006-12-22 19:36 UTC, Guilhèm Bonnefille
none Details | Review
small revision (1.21 KB, patch)
2007-01-08 20:10 UTC, Charles Kerr
committed Details | Review

Description Guilhèm Bonnefille 2006-12-22 19:24:36 UTC
When a connection fails, the error message only reported that something wrong occured.

It would be better to indicate more precisely the error (via strerror) and the server concerned by the error.

Other information:
Comment 1 Guilhèm Bonnefille 2006-12-22 19:28:31 UTC
Created attachment 78805 [details] [review]
Improve the g_message calls while socket creation errors
Comment 2 Guilhèm Bonnefille 2006-12-22 19:36:30 UTC
Created attachment 78807 [details] [review]
Improve the message that occurs when the connection failed

This patch breaks some translations.
Comment 3 Charles Kerr 2007-01-08 20:10:50 UTC
Created attachment 79781 [details] [review]
small revision

use pan_strerror instead of g_strerror to avoid possibility of
passing NULL to the final %s
Comment 4 Charles Kerr 2007-01-08 20:12:24 UTC
fixed in svn