GNOME Bugzilla – Bug 387537
Use "user-bookmarks" named icon for Places->Bookmarks
Last modified: 2008-11-24 18:34:59 UTC
The Places->Bookmarks menu entry appears when you have a lot of bookmarked locations. Currently this menu entry is using the "stock_bookmark" named icon from gnome-icon-theme. After the recent switch to Icon Naming Spec and Tango Style, this icon is deprecated. A solution to have a good icon (in appearance, name and installation path) could be install it as app-specific named icon (see [1] for details). But 'cause the same icon could be used in other apps (Nautilus, file-chooser) and panel is a core application in GNOME Desktop, I'll ask on theme list to comment about this bug. Meanwhile I'll prepare icons to install within gnome-panel (merging the folder icon from gnome-icon-theme and the recent bookmark-view icon in Epiphany) and a patch to use it. Also I'n not sure about name... Maybe "folder-bookmarks" or "bookmark-folders"? [1] http://live.gnome.org/ThemableAppIcons
Created attachment 78630 [details] A quick but cool SVG icon for bookmarked folders
Created attachment 78631 [details] [review] The proposed path to code The patch to use panel-specific themeable icon is really trivial. Of course you need images installed at $(prefix)/share/gnome-panel/icons/hicolor/<size>/<context>
Created attachment 78632 [details] A screenshot showing new icon in use
I'd prefer if it was not an app-specific icon. Any reply about this on the theme list?
(In reply to comment #4) > I'd prefer if it was not an app-specific icon. Any reply about this on the > theme list? > No replies :-( Currenly only icons from Icon Naming Spec are allowed in gnome-icon-theme, so we should ask for a new common named icon.
Btw, I'm not forgetting about this patch, but I won't commit this before you get a reply about the not-app-specific icon.
*** Bug 481001 has been marked as a duplicate of this bug. ***
Vincent, what about use a simple and standard "folder-open"? It's defined in fd.o Naming Spec, provided by gnome-icon-theme and other Naming Spec compliant icon themes, represents a folder and you don't need to provide custom icons for panel. A good compromise, IMHO.
Created attachment 103191 [details] [review] Patch to use "folder-open" icon
Created attachment 103192 [details] Screenshot with latest proposed patch.
On my System Places/Bookmarks already uses a different icon: http://www.nanolx.org/panel.png (Screenshot) It uses either stock_bookmark or gtk-stock-book (both are the same). I guess it's just the icon that's missing.
*** Bug 520809 has been marked as a duplicate of this bug. ***
Why don't we use the fdo's 'user-bookmark' icon? I just checked out the spec, though the icon is not yet designed however it IS in the naming spec. Check out at http://people.freedesktop.org/~jimmac/icons/#tit Go to Places section. IMHO, this is the best solution ;)
Edit: I mean add those 2 icons into the naming-spec, we don't to make git dirty right? ;)
Created attachment 111033 [details] [review] the patch to use fd.o's 'user-bookmarks' icon The Luca's patch is no longer a valid patch since the structure of gnome-panel has changed. So this is a valid one.
Comment on attachment 111033 [details] [review] the patch to use fd.o's 'user-bookmarks' icon user-bookmarks icon
I agre, "user-bookmars" was recently added to Icon Naming Spec and gnome-panel should use it. * changed bug summary * added deps on gnome-icon-theme bug * obsoleted previous patches * reviewed latest patch * target for 2.23/24 Vincent, OK to commit when the new icon will be available in gnome-icon-theme?
(In reply to comment #17) > Vincent, OK to commit when the new icon will be available in gnome-icon-theme? I was actually waiting to see the icon appear in gnome-icon-theme before applying the patch :-)
Luca: So is the new icon in for gnome-icon-theme now? Otherwise we should push to get http://bugzilla.gnome.org/show_bug.cgi?id=387537#c1 in...
Just checked http://people.freedesktop.org/~jimmac/icons The icon is not yet up, and I don't see any point push a custom icon then get it removed shortly after. Better we wait.
OK. Then it's definitely not a GNOME target - unsetting the milestone.
The user-bookmarks icon is now added to g-i-t: Revision 1846 - (view) (annotate) - [select for diffs] Modified Wed Aug 13 16:05:27 2008 UTC (2 days, 22 hours ago) by andreasn File length: 203390 byte(s) Diff to previous 1842 added user-bookmarks icon It is finally time to apply the patch! Yay!
This patch has already been committed, please close... trunk/gnome-panel/ panel-icon-names.h 1/1 Mon Aug 18 19:17:54 2008 UTC 2008-08-18 Baptiste Mille-Mathias <baptiste.millemathias@gmail.com> * gnome-panel/panel-icon-names.h: change the bookmark icon name according to latest gnome-icon-theme, so version 2.23.90 is needed now. Patch from Michael Monreal <michael.monreal@gmx.net>. Fix bug #547626.
*** This bug has been marked as a duplicate of 547626 ***