After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 387137 - Regression: qtdemux paletted image handling
Regression: qtdemux paletted image handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-18 12:54 UTC by Jan Schmidt
Modified: 2006-12-18 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (853 bytes, patch)
2006-12-18 12:55 UTC, Jan Schmidt 		none Details | Review
better more different patch (1.76 KB, patch)
2006-12-18 13:24 UTC, Jan Schmidt 		none Details | Review

Description Jan Schmidt 2006-12-18 12:54:51 UTC 
qtdemux throws a g_warning for a case that it used to silently get wrong, which makes the media testsuite show a regression.

Attaching a patch that sends a WARNING message on the bus and then ignores the stream instead.
Comment 1 Jan Schmidt 2006-12-18 12:55:54 UTC 
Created attachment 78561 [details] [review]
patch
Comment 2 Jan Schmidt 2006-12-18 13:24:37 UTC 
Created attachment 78563 [details] [review]
better more different patch

updated patch that catches the no-pad case in streaming mode
Comment 3 Jan Schmidt 2006-12-18 13:42:36 UTC 
Fixed in CVS:
        * gst/qtdemux/qtdemux.c: (gst_qtdemux_chain),
        (gst_qtdemux_add_stream):
          Don't output g_warning for an unsupported format, just send a
          GST_ELEMENT_WARNING and don't add the pad.
          Fix the case where it doesn't check for a NULL pad in streaming mode.
          Fixes #387137