GNOME Bugzilla – Bug 386411
Depricate gnome-session from directly starting any ATs
Last modified: 2007-05-06 08:02:57 UTC
gnome-session should no longer try to start the assistive technologies. /usr/share/gnome/autostart/gnome-at-session.desktop with the help of /usr/bin/gnome-at-visual now starts the assistive technologies according to what was set in Preferred Applications. See bug 350263.
Rationale http://live.gnome.org/GAP/ScratchPad/PreferredAppliations
Created attachment 78710 [details] [review] Don' launch any ATs from gnome-session This patch removes launching the apps that were included in the now deprecated exec_ats key. Might want to try it with your environment. ariel
This patch looks reasonable to me (but I can't approve patches). A ChangeLog entry would be nice :-)
I removed some more code and committed this. 2007-01-06 Vincent Untz <vuntz@gnome.org> * gsm-at-startup.[ch]: (gsm_assistive_tech_exec): kill (gsm_assistive_registry_start): directly call gsm_exec_command_line_async() instead of gsm_assistive_tech_exec() (gsm_assistive_technologies_start): kill * main.c: (main): don't call gsm_assistive_technologies_start() Fix bug #386411, based on patch by Ariel Rios <ariel@gnu.org>
Vincent, thanks for committing this code. Unfortunately, the gnome-cc maintainers are deferring 350263 until 2.20. This patch without the other breaks accessibility. I'm afraid this patch needs to be backed out.
Created attachment 81960 [details] [review] Patch used to revert This is how it got reverted. Will be useful when fixing this in 2.19.
Please reapply patch after 350263 is committed.
350263 is now committed, so you can reapply this
The prerequsite patch has been applied, so /usr/share/gnome/autostart/gnome-at-session.desktop is now responsible for starting the assistive technologies. Please reapply this this patch to remove the dead code in gnome-session which tries to start orca, magnifier, and gok. Thanks.