GNOME Bugzilla – Bug 386226
Toolbar icons in old gnome-style
Last modified: 2007-08-15 04:43:15 UTC
Please describe the problem: The toolbar icons in evince is currently drawn i the old gnome-style. The icons need to follow the tango style guidelines to fit in with the rest of GNOME. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 78434 [details] New icons for page-view-facing and page-new-continuous These should be installed according to these instructions in order to be themeable. http://live.gnome.org/ThemableAppIcons
Thanks, looks good. Any chance you can come up with a zoom-fit-width icon?
Created attachment 78437 [details] zoom-fit-width in 16x16 and 22x22
Thanks, I'll look into it later!
Created attachment 78556 [details] [review] The patch to use app-specific themeable icons when installed. Here are all needed changes to evince source to use those new app-specific themable icons as well as "view-restore" for Exit Fullscreen action instead deprecated icon. Icons Issues: * Andreas, should "page-view-cont" icon in you package named "page-view-continuous"? * Also, "page-view-*" or "view-page-*"? IMHO the second. Missing Icons: * "zoom-fit-page" Missing Named Icons[1]: * "view-sidepane" --> in toolbar to view/hide the side pane (maybe "open-*"?) * "go-previous-page" --> for Back toolbar item (link history). Maybe something like the new History incon in Epiphany, but replacing the clock with a paper? Other Issues: * The latest gnome-icon-theme provides an update "edit-select-all" icon. Evince is using the GTK_STOCK item, but it seems that there is no rule in current icon-naming-utils to create the needed link. 'cause Evince is yet using some icons from the Icon Naming Standard, we could replace the GTK_STOCK with the new named icon without waiting for a new icon-naming-utils release. [1] Icons not yet defined and/or used in Evince sources
Of course Missing Named Icons are also Missing Icons :-)
Created attachment 78559 [details] Fixed the names
Created attachment 78565 [details] [review] Same patch, but using "continuous"
Created attachment 78567 [details] [review] New patch, fixing names (view-page*) and applying changes to ev-stock-icons.h file too
* "go-previous-page" --> for Back toolbar item (link history). Maybe something Where is that used, is it new? Can't find it in 0.6.1, I'm afraid. I'll get on view-sidepane. Not convinced about the use of it, but whatever, I'll shut up and draw. ;)
Created attachment 78573 [details] view-sidepane in 16x16 and 22x22 Kind of crappy icon for view-sidepane. I would rather see the sidepane button removed than using this.
(In reply to comment #10) > * "go-previous-page" --> for Back toolbar item (link history). Maybe > something > > Where is that used, is it new? > Can't find it in 0.6.1, I'm afraid. It's a new feature of development version (just relased the 0.7.0) When the document you are viewing has internal links, you can click and jump to target. You can add on toolbar a "Back" button (by now showing the "go-down" arrow) to open a drop down list of the pages before each jump. Something like the history arrow buttons on Epiphany or Nautilus toobars.
It should be noted this is VERY MUCH a work in progress, so don't expect it to become a default toolbar item in the near future...
*** Bug 340573 has been marked as a duplicate of this bug. ***
Any news? Is it OK to commit at least ready stuff (i.e. my patch in comment #9 and related icons from Andreas)?
There's a release planned today, so please wait a bit. Feel free to mess around in svn tomorrow... apply your patch and make sure it works :)
Hm, I am slightly opposed to this idea. For me it seems dumb do have a separate dir into /usr/share/evince for our own icons. We don't need app-specific icons, we extremely need common icons for all applications. Were there discussion on d-d-l about new icons location? At least I don't remember anything similar.
It's not a new icon location, it's just the best way to provide fresh (aka Tango-style) and themeable icons using available GTK+ features, avoiding to install them in the shared $prefix/share/icons/hicolor creating collisions. Currently only icons defined in Icon Naming Spec are accepted by gnome-icon-theme maintainers. "Legacy" icons (stuff under stock/* directories) are unmaintained. There was some threads on desktop-devel-list about current gnome-icon-theme goals: * http://mail.gnome.org/archives/desktop-devel-list/2006-January/msg00302.html * http://mail.gnome.org/archives/desktop-devel-list/2006-February/msg00024.html * http://mail.gnome.org/archives/desktop-devel-list/2006-July/msg00797.html (mostly complaints about the switch...) Of course there are common icons not listed in Icon Naming Spec that could be used by different applications. For example a "playlist" icons could be shared by different audio applications (Totem, Rhythmbox, Banshee). The long term plan is provide special subsets of icon theme. For example we'll have gnome-icon-theme-mime (providing "audio-x-mp3" and "audio-x-ogg", while the basic set defines only "audio-x-generic" for all audio files) or gnome-icon-theme-device (media-optical-cd, media-optical-cd-r, media-optical-cd-rw and so on). There are yet two proposal on tango web site (http://tango.freedesktop.org/ArtLibreSet and http://tango.freedesktop.org/CodeTangoSet) and others will come. By now we are trying to complete the basic set, the one defined by Icon Naming Spec, but we also like to see more Tango-style icons in applications (see for example recent changes in Epiphany). So the workaround solution is install icons as custom app icons and use them as named icon in sources (using the best name for theme). So, when new sets will be ready, you can simply remove custom icons from build and in case change names. Of course some application could need icons not listed in any sub-spec, so the custom app icon workaround will be the only available way to install those custom icons in a neat way, keeping theme themeable. I wrote an email on d-d-l [1], but there was no reply. However currently Epiphany, Epiphany-extensions, FileRoller and Brasero are using this approach. [1] http://mail.gnome.org/archives/desktop-devel-list/2006-December/msg00137.html
Sorry, Luca, I've incorrectly spelled your mail. I've just replied on ddl http://mail.gnome.org/archives/desktop-devel-list/2007-January/msg00344.html
Heh, ok, you've convinced me. So it would be nice if someone will commit everything here.
Great, I'm doing it.
Commited view-page-facing, view-page-continuous, zoom-fit-width and zoom-fit-page icons (zoom-fit-page is just the zoom-fit-width from Andreas, but using a vertical arrow). Also I moved Evince icons from <size>/evince.<ext> to <size/apps/evince.<ext>.
Thanks Luca, this bug should be closed then. I've just modified your patch slightly to use icon-theme associated with current window screen.
Created attachment 92891 [details] view-page actions in 32x32 and 48x48 Although this is bug closed, I realised we were missing the 32x32 and 48x48 sizes of these actions. HighContrast versions in the works.
Reopening.
Applied, thanks a lot!