GNOME Bugzilla – Bug 386193
should be able to check for GNUmakefile
Last modified: 2007-01-10 00:09:41 UTC
Please describe the problem: AbiWord is using "GNU" prefixed makefiles for historical reasons. It would be nice if jbhuild supported looking for GNUmakefile in addition to Makefile in the toplevel project directory, when pondering whether to autogen or just make. An additional, optional parameter in the .modules file would seem reasonable, maybe something like <autotools id="libabiword" autogenargs="..." makefile="GNUmakefile"> Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
I think it make sense to automatically check both makefiles naming, since make supports both. I'm going to attach a patch.
Created attachment 78826 [details] [review] Check for both Makefile and GNUmakefile, also ensure the .am actually exists OK to commit?
Can someone have a look to the patch please?
Why do you have to ensure the .am actually exists? I believe it will break the usage of autogen-sh, such as <autotools id="automake-1.4" autogen-sh="configure">
libabiword has both a GNUmakefile.am and a Makefile in the root directory, so checking for makefile only would not work. To solve the autogen-sh issue would it be enough to also check for makefile + '.in' ?
Alternatively, as initially suggested by Robert, we can add a makefile optional parameter. Let me know what you prefer.
Frederic, what do you think?
(sorry for late answer) No strong preference here but I think a new attribute will be more explicit.
Created attachment 79897 [details] [review] Add a makefile argument OK to commit?
Fine by me.