After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 385887 - [flac] make work with libflac-1.1.3
[flac] make work with libflac-1.1.3
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-14 16:01 UTC by Tim-Philipp Müller
Modified: 2007-06-10 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to make flac plugin work with flac-1.1.3 (34.31 KB, patch)
2006-12-14 16:03 UTC, Tim-Philipp Müller 		none Details | Review
patch ported to gst-plugins-good 10.5 release (35.99 KB, patch)
2007-05-13 09:22 UTC, Alexis Ballier 		committed Details | Review

Description Tim-Philipp Müller 2006-12-14 16:01:56 UTC 
Attaching patch posted by Josh Coalson <xflac@yahoo.com> to gstreamer-devel on 21 Nov 2006 (and before) to make our flac plugin work with the upcoming/new 1.1.3 release.

Punting commit until after the upcoming -good release.
Comment 1 Tim-Philipp Müller 2006-12-14 16:03:31 UTC 
Created attachment 78364 [details] [review]
patch to make flac plugin work with flac-1.1.3
Comment 2 Alexis Ballier 2007-01-08 07:51:58 UTC 
Please note that it is also needed to update configure checks for flac 1.1.3, see : http://bugs.gentoo.org/show_bug.cgi?id=157707
Comment 3 Alexis Ballier 2007-05-13 09:22:08 UTC 
Created attachment 88110 [details] [review]
patch ported to gst-plugins-good 10.5 release

Here is the full patch ported to 10.5 release of gst-plugins-good.
That would be very nice if it could be included ;)
Comment 4 Sebastian Dröge (slomo) 2007-06-09 22:08:06 UTC 
IMHO we should get this for the next -good release, thus marking it as a blocker. 1.1.3 and 1.1.4 are out since ages already.
Comment 5 Sebastian Dröge (slomo) 2007-06-10 10:53:58 UTC 
2007-06-10  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Josh Coalson <xflac at yahoo dot com>,
        updated by Alexis Ballier <aballier at gentoo dot org>:

        * configure.ac:
        * ext/flac/gstflacdec.c: (gst_flac_dec_reset_decoders),
        (gst_flac_dec_setup_seekable_decoder),
        (gst_flac_dec_setup_stream_decoder), (gst_flac_dec_seek),
        (gst_flac_dec_tell), (gst_flac_dec_length), (gst_flac_dec_eof),
        (gst_flac_dec_read_seekable), (gst_flac_dec_read_stream):
        * ext/flac/gstflacdec.h:
        * ext/flac/gstflacenc.c: (gst_flac_enc_init),
        (gst_flac_enc_finalize), (gst_flac_enc_set_metadata),
        (gst_flac_enc_sink_setcaps), (gst_flac_enc_update_quality),
        (gst_flac_enc_seek_callback), (gst_flac_enc_write_callback),
        (gst_flac_enc_tell_callback), (gst_flac_enc_sink_event),
        (gst_flac_enc_chain), (gst_flac_enc_set_property),
        (gst_flac_enc_get_property), (gst_flac_enc_change_state):
        * ext/flac/gstflacenc.h:
        Add support for flac >= 1.1.3 which changes API. Fixes bug #385887.