After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 385267 - Creating a new album in Web Gallery urlencodes the data twice
Creating a new album in Web Gallery urlencodes the data twice
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-13 00:20 UTC by Aidan Skinner
Modified: 2007-02-23 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Here is a patch (1.59 KB, patch)
2006-12-13 00:25 UTC, Aidan Skinner 		committed Details | Review

Description Aidan Skinner 2006-12-13 00:20:39 UTC 
Please describe the problem:
When you create a new album in Gallery f-spot ends up urlencoding the data, so you end up with Albums named A+test+album which is ugly.

Steps to reproduce:
1. Select a photo, go to File -> Export -> Web Gallery
2. Create a new album
3. Enter the data and hit OK


Actual results:
See the result with extra +'s and the like

Expected results:
The album to be created without the urlenocded characters

Does this happen every time?
Yes

Other information:
Comment 1 Aidan Skinner 2006-12-13 00:25:28 UTC 
Created attachment 78249 [details] [review]
Here is a patch

I changed FormClient to optionally accept a bool for multipart and made Gallery2.NewAlbum set that to be true to bypass the urlencoding.

It would probably be better to change FormClient to not urlencode anything at all, since it always POSTs, but I don't have a Fotki account to test that.
Comment 2 Michael R Head 2007-02-23 15:51:03 UTC 
Will this patch fix the same problem with gallery v1 remote?
Comment 3 Stephane Delcroix 2007-02-23 20:26:57 UTC 
I committed a slightly different version of the patch to svn in r2970. I also set the multipart property to true for exports to G1.