GNOME Bugzilla – Bug 385037
history should open the selected page to a new tab
Last modified: 2007-12-19 21:51:23 UTC
That bug has been described on https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/75122 "Binary package hint: epiphany-browser When you double-click a link in the History window, it opens in a new window even though the first option on the right-click menu is to open it on a new tab, and my system is set to open links on new tabs. Shouldn't epiphany be opening those links on new tabs by default, then? ... > Thank you for your bug. Where do you select the option "to open links on new tabs"? What version of Ubuntu do you use? ... I'm on Feisty, but that has been the behaviour since I started using Epi some long time ago. I'll try to be a bit more specific. I selected "open links in a new tab" in the preferred apps menu: http://img214.imageshack.us/img214/1985/pantallazoaplicacionespfw8.png Epi's bookmark first menu item is to open the link in a new tab: http://img183.imageshack.us/img183/2231/sinnombreos2.jpg Yet, if you double-click a history item, it opens in a new window. ... > The "preferred app" is used to determine what application should be called when clicking on an http URI from some other desktop application and is not an epiphany preference ..."
I don't think this is a valid bug. Tabs should only be opened on specific user request. Opening in new tabs is nowhere in Epiphany the default, on purpose, since it is an advanced feature.
What if we detect if user is pressing control and if that's the case we open a new tab.
Sure. Or middle click. As long as the same behaviour goes for history and bookmark entries.
It seems like a regression of bug 120678. The "open in new tab" option in the Standard Applications preferences window isn't respected right now.
*** Bug 499866 has been marked as a duplicate of this bug. ***
Created attachment 99711 [details] [review] [1/3] Added node-middle-clicked signal to EphyNodeView As there has been a request for this lately, I made a patch to implement middle-click to open a new tab in bookmark editor and history window.
Created attachment 99712 [details] [review] [2/3] Use middle click for bookmarks editor
Created attachment 99713 [details] [review] [3/3] use middle click for history window
Shouldn't we handle ctrl-leftclick like middleclick too ?
For me, yes, it would be consistent. :)
Ctrl+leftclick is used to select multiple entries in the treeview...I don't think we should override it, as it's the only way I know to do that.
You're right, I forgot about multi-selection. Let's get this in; thanks for the patches.
Committed, closing as FIXED. ------------------------------------------------------------------------ r7791 | cosimoc | 2007-12-19 22:46:55 +0100 (mer, 19 dic 2007) | 3 lines Middle click on entries in History Window and Bookmark Editor opens the page in a new tab. Close bug #385037.