GNOME Bugzilla – Bug 383726
[audiopanorama] only transforms half of the samples in float mode
Last modified: 2006-12-08 16:38:57 UTC
Hi, currently audiopanorama only transforms one half of the samples when working in float mode. It can accept 16 bit int or 32 bit float samples, the num_samples calculation in the transform function only assumes 16 bit int samples. Attached is a patch to fix this (by adding a new instance variable width). I decided to fix it this way because getting caps of the buffer, reading the structure of the caps and reading the width element of it would be unnecessary overhead in the transform function and it shouldn't change without calling the caps function anyway. Bye
Created attachment 77959 [details] [review] audiopanorama.diff
Patch by: Sebastian Dr��ge <mail at slomosnail de > * gst/audiofx/audiopanorama.c: (gst_audio_panorama_init), (gst_audio_panorama_set_caps), (gst_audio_panorama_transform): * gst/audiofx/audiopanorama.h: Fix audiopanorame with float samples. Fixes #383726.