After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 383686 - Remove redundant code that is now in GLib
Remove redundant code that is now in GLib
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
1.10.x (obsolete)
Other Linux
: High enhancement
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[codecleanup]
Depends on:
Blocks:
 
 
Reported: 2006-12-08 10:24 UTC by Ross Burton
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate e_util_mkdir_hier (13.53 KB, patch)
2006-12-08 10:27 UTC, Ross Burton 		reviewed Details | Review
Revised patch (11.18 KB, patch)
2007-04-04 20:55 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2006-12-08 10:24:14 UTC 
As of EDS 1.9.1, GLib 2.10 is a build requirement.

This means that a lot of duplicated code in EDS can be remove, such as the local implementation of e_util_mkdir_hier().  Attaching a series of patches to remove all of this.
Comment 1 Ross Burton 2006-12-08 10:27:59 UTC 
Created attachment 77953 [details] [review]
Deprecate e_util_mkdir_hier

This patch deprecates e_util_mkdir_hier, makes it simply call g_mkdir_with_parents(), and changes EDS to use Glib directly.
Comment 2 Kjartan Maraas 2007-01-25 14:30:57 UTC 
Please review someone
Comment 3 Matthew Barnes 2007-03-25 19:39:46 UTC 
Looks great, except I'd prefer to see

   #ifndef EDS_DISABLE_DEPRECATED
   int          e_util_mkdir_hier (const char *path, mode_t mode);
   #endif

in e-data-server-util.h, so that Gtk-Doc marks it as deprecated.
(see libedataserver/e-msgport.h for other examples)

Have you found any other functions like this?  I'm on the hunt for them too.
Comment 4 Ross Burton 2007-04-04 20:55:59 UTC 
Created attachment 85825 [details] [review]
Revised patch

This patch removes a few more uses of e_util_mkdir_hier, and wraps the prototype in DEPRECATED guards.
Comment 5 Matthew Barnes 2007-04-04 21:19:08 UTC 
Looks good, thanks Ross!
Comment 6 Ross Burton 2007-04-05 09:33:38 UTC 
Committed. Thanks!