After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 383497 - build fails: deprecated macros used in libbonoboui
build fails: deprecated macros used in libbonoboui
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonoboui
CVS HEAD
Other All
: Normal blocker
: ---
Assigned To: Michael Meeks
bonobo qa
: 383339 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-12-07 20:06 UTC by Ben Gamari
Modified: 2006-12-10 15:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
remove dependency on deprecated gnome-macros (34.29 KB, patch)
2006-12-09 08:49 UTC, P. Henrique Silva 		none Details | Review

Description Ben Gamari 2006-12-07 20:06:15 UTC 
Please describe the problem:
The deprecated macro GNOME_CLASS_BOILERPLATE is used in both bonobo-dock.c and bonobo-dock-item.c. This was using HEAD libbonoboui against HEAD libgnome.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Frederic Peters 2006-12-08 08:38:55 UTC 
Quick "fix" removing -DGNOME_DISABLE_DEPRECATED from bonobo/Makefile.am

Long fix using G_DEFINE_TYPE and so on to replace deprecated parts.
Comment 2 Ben Gamari 2006-12-08 16:48:05 UTC 
yep, I know. I managed to work around it fine. I'm just making sure you guys know. Are bug reports of this nature helpful or needed?
Comment 3 P. Henrique Silva 2006-12-09 08:49:54 UTC 
Created attachment 78004 [details] [review]
remove dependency on deprecated gnome-macros

Here is a patch that removes the dependency on GNOME_CLASS_BOILERPLATE and GNOME_CALL_PARENT, using the recommended G_DEFINE_TYPE.

There is a discussion [1] about provide a macro replacement for GNOME_CALL_PARENT, but as long as I saw the only bad point about don't use this macro it's the *big* name of the parent class and this can be error prone. I'll post to [1] telling about this patch. Anyway, there was places in bonoboui that simply doesn't use GNOME_CALL_PARENT, so this could indicate that this macro is really unnecessary.

[1] http://bugzilla.gnome.org/show_bug.cgi?id=327840
Comment 4 Christian Kirbach 2006-12-09 10:37:56 UTC 
*** Bug 383339 has been marked as a duplicate of this bug. ***
Comment 5 Christian Kirbach 2006-12-09 10:43:29 UTC 
Ben: of course , please report build failures.
Comment 6 Gustavo Carneiro 2006-12-10 15:59:28 UTC 
Fixed in CVS. The fix will go into the next patch release. Thank you for your bug report.
Thanks for the patch :-)