Created attachment 77837 [details] [review]
patch

OK to commit this?

Before I review the code, do you have screenshots?

Created attachment 77839 [details]
screenshot - changing volume

Created attachment 77840 [details]
screenshot - ejecting a disc

Wouldn't it be better to keep the old dialogues when compositing is off (ie. when gdk_screen_is_composited returns FALSE)?

I had something like that in a early version of the patch.  However, it added complexity with basically no upside.  It also made it a bit more difficult to handle the composited-changed case.  Its just an entirely different (parallel) way of doing things.

However, it is possible and I'll add it if that is required.

Created attachment 77905 [details] [review]
patch

This uses the glade widgets when not composited.  Look OK?

Looks good to me.

Looks ok to me also, please commit and close the bug

Thanks for the really quick review and approvals guys!  Feel free to copy me on bugs related to this in the future.

2006-12-07  William Jon McCann  <mccann@jhu.edu>

	* gnome-settings-daemon/Makefile.am:
	* gnome-settings-daemon/actions/Makefile.am:
	* gnome-settings-daemon/actions/acme.glade:
	* gnome-settings-daemon/actions/gnome-speakernotes-muted.png:
	* gnome-settings-daemon/actions/gnome-speakernotes.png:
	* gnome-settings-daemon/gnome-settings-multimedia-keys.c:
	(execute), (dialog_init), (unhookup_keysym), (update_kbd_cb),
	(init_kbd), (dialog_show), (do_eject_action), (do_sound_action),
	(gnome_settings_multimedia_keys_load):
	* gnome-settings-daemon/gsd-media-keys-window.c: (hide_timeout),
	(remove_hide_timeout), (add_hide_timeout), (update_window),
	(volume_controls_set_visible), (window_set_icon_name),
	(window_set_icon_file), (action_changed), (volume_level_changed),
	(volume_muted_changed), (gsd_media_keys_window_set_action),
	(gsd_media_keys_window_set_volume_muted),
	(gsd_media_keys_window_set_volume_level), (curved_rectangle),
	(draw_action_eject), (draw_waves), (draw_speaker),
	(draw_volume_boxes), (draw_action_volume), (draw_action),
	(on_expose_event), (gsd_media_keys_window_real_show),
	(gsd_media_keys_window_real_hide),
	(gsd_media_keys_window_class_init), (initialize_alpha_mode),
	(gsd_media_keys_window_init), (gsd_media_keys_window_finalize),
	(gsd_media_keys_window_new):
	* gnome-settings-daemon/gsd-media-keys-window.h:
	Add a new media keys window that takes advantage of
	compositing when available.  Fixes #383066

This is very nice but I get anoying "jumping" of the media key window after the first press, meaning I press once, window appears, i press again and the window jumps some pixels to the upper left. After that it doesn't move again for that session. Can this be fixed? I'm using latest compiz (from git) bzw, donno if this could be the cause?

I think the gnome-power-manager brightness control display will not be consistent with this anymore?

Suggestions?

- Open up bug in g-p-m and extend it's window drawing with this functionality?
OR
- Add brightness controls here and let g-p-m somehow call it?

(In reply to comment #12)
> I think the gnome-power-manager brightness control display will not be
> consistent with this anymore?
> 
> Suggestions?
> 
> - Open up bug in g-p-m and extend it's window drawing with this functionality?
> OR
> - Add brightness controls here and let g-p-m somehow call it?

I filed bug 400844 about it


(In reply to comment #11)
> This is very nice but I get anoying "jumping" of the media key window after the
> first press, meaning I press once, window appears, i press again and the window
> jumps some pixels to the upper left. After that it doesn't move again for that
> session. Can this be fixed? I'm using latest compiz (from git) bzw, donno if
> this could be the cause?

Please open a new bug about that.