After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 383043 - Videomixer can crash when adding/removing pads while playing
Videomixer can crash when adding/removing pads while playing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-06 16:23 UTC by Sjoerd Simons
Modified: 2006-12-16 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Introduce some locking around the videomixer state (5.62 KB, patch)
2006-12-06 16:24 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2006-12-06 16:23:26 UTC 
The videomixer has a list of sinkpads and some other misc data dependant on the pads it has and uses this inside it's _collected function. Unfortunately adding or removing a pad while in the playing state can change this lists while the _collected function uses them. Which leads to unexpected things (such as crashes)
Comment 1 Sjoerd Simons 2006-12-06 16:24:03 UTC 
Created attachment 77831 [details] [review]
Introduce some locking around the videomixer state
Comment 2 Wim Taymans 2006-12-16 16:21:44 UTC 
        Patch by: Sjoerd Simons <sjoerd at luon dot net>

        * gst/videomixer/videomixer.c: (gst_videomixer_pad_set_property),
        (gst_videomixer_set_master_geometry),
        (gst_videomixer_pad_sink_setcaps), (gst_videomixer_collect_free),
        (gst_videomixer_reset), (gst_videomixer_init),
        (gst_videomixer_finalize), (gst_videomixer_request_new_pad),
        (gst_videomixer_release_pad), (gst_videomixer_collected),
        (gst_videomixer_change_state):
        Introduce some locking around the videomixer state so that it does not
        crash when adding/removing pads. Fixes #383043.