After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 383022 - Non-portable __FUNCTION__ macro used - breaks Solaris
Non-portable __FUNCTION__ macro used - breaks Solaris
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other Solaris
: Normal normal
: ---
Assigned To: GNOME main menu maintainers
GNOME main menu maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-06 15:08 UTC by Damien Carbery
Modified: 2007-02-18 18:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Use G_GNUC_FUNCTION macro. (1.54 KB, patch)
2006-12-06 15:09 UTC, Damien Carbery 		accepted-commit_now Details | Review

Description Damien Carbery 2006-12-06 15:08:14 UTC 
In libslab/document-tile.c and libslab/gnome-utils.c, the __FUNCTION__ macro is used. This breaks the build on Solaris.
Please use the portable G_GNUC_FUNCTION macro, defined in /usr/include/glib-2.0/glib/gmacros.h.
Comment 1 Damien Carbery 2006-12-06 15:09:24 UTC 
Created attachment 77818 [details] [review]
Use G_GNUC_FUNCTION macro.
Comment 2 Thomas Wood 2007-01-06 20:52:38 UTC 
This is a libslab issue, but I can't see any reason not to commit the patch.
Comment 3 Thomas Wood 2007-01-17 17:37:59 UTC 
Moving to libslab component.
Comment 4 Rodrigo Moya 2007-02-12 21:22:32 UTC 
Patch approved by Scott and committed to svn trunk
Comment 5 Christian Persch 2007-02-18 18:50:06 UTC 
Debug output is now useless since G_GNUC_FUNCTION expands to "" on gcc >= 3.0.